HomePhabricator

wallet: Initialize stop_block to nullptr in ScanForWalletTransactions

Description

wallet: Initialize stop_block to nullptr in ScanForWalletTransactions

Summary:

Previously the argument would be untouched if the first block scan
failed. This makes the behavior predictable, and consistent with the
documentation.

Backport of core PR14957 and the remaining of PR15321 (see D5238).

Depends on D5563.

Test Plan:
With Clang:

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON
ninja all check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5564

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on Dec 14 2018, 07:18
FabienCommitted on Mar 26 2020, 12:37
FabienPushed on Mar 26 2020, 12:37
Reviewer
Restricted Project
Differential Revision
D5564: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions
Parents
rABC83af2fc46898: Add stop_block out arg to ScanForWalletTransactions
Branches
Unknown
Tags
Unknown