wallet: Initialize stop_block to nullptr in ScanForWalletTransactions
ClosedPublic
Actions

Authored by Fabien on Mar 25 2020, 17:16.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING07d651060a3f: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions
rABC07d651060a3f: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions

Summary

Previously the argument would be untouched if the first block scan
failed. This makes the behavior predictable, and consistent with the
documentation.

Backport of core PR14957 and the remaining of PR15321 (see D5238).

Depends on D5563.

Test Plan

With Clang:

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON
ninja all check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14957

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9966
Build 17784: Default Diff Build & Tests
Build 17783: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 25 2020, 17:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 17:16

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9966: Diff 17166.Mar 25 2020, 17:26

deadalnix accepted this revision.Mar 25 2020, 19:02

This revision is now accepted and ready to land.Mar 25 2020, 19:02

Closed by commit rABC07d651060a3f: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyMar 26 2020, 12:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC07d651060a3f: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions.

Fabien added a commit: rSTAGING07d651060a3f: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions.Apr 7 2020, 23:29

Revision Contents
Changeset List

Path

Size

src/

wallet/

test/

wallet_tests.cpp

70 lines

wallet.cpp

1 line

Diff 17166

View Options

src/wallet/test/wallet_tests.cpp