Page MenuHomePhabricator

Prevent arc land from failing if there is nothing to lint
ClosedPublic

Authored by Fabien on Tue, Feb 11, 14:24.

Details

Summary

If there is not path to lint, the lint workflow will print `No paths are
lintable. and throw an ArcanistNoEffectException`.
When running arc lint, this exception is catched and returns no error,
but when run as part of arc land this logic is missing.

Test Plan

Delete a file then run arc land --preview; it should not fail the lint
stage.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Feb 11, 14:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 11, 14:24
markblundeberg accepted this revision.Tue, Feb 11, 14:32
This revision is now accepted and ready to land.Tue, Feb 11, 14:32
This revision was landed with ongoing or failed builds.Tue, Feb 11, 14:33
This revision was automatically updated to reflect the committed changes.