Page MenuHomePhabricator

Prevent arc land from failing if there is nothing to lint
ClosedPublic

Authored by Fabien on Feb 11 2020, 14:24.

Details

Summary

If there is not path to lint, the lint workflow will print `No paths are
lintable. and throw an ArcanistNoEffectException`.
When running arc lint, this exception is catched and returns no error,
but when run as part of arc land this logic is missing.

Test Plan

Delete a file then run arc land --preview; it should not fail the lint
stage.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arc_land_no_lint_path
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9437
Build 16803: Default Diff Build & Tests
Build 16802: arc lint + arc unit