Page MenuHomePhabricator
Feed Advanced Search

Yesterday

markblundeberg accepted D2563: Added missing release notes for 0.19.
Mon, Feb 18, 19:25
Herald added a reviewer for D2562: un-mention segwit in addnode help text: deadalnix.
Mon, Feb 18, 15:45

Sun, Feb 17

markblundeberg added inline comments to D2457: [schnorr] Refactor the signature process in reusable component.
Sun, Feb 17, 01:16

Sat, Feb 16

markblundeberg updated the diff for D2559: fix Qt crash.

s/Qt/bitcoin-qt

Sat, Feb 16, 03:40
markblundeberg updated the diff for D2559: fix Qt crash.

add release note

Sat, Feb 16, 03:35
Herald added a reviewer for D2559: fix Qt crash: deadalnix.
Sat, Feb 16, 03:02
markblundeberg added a comment to D2322: remove minimum total fee option.

Need fix: https://github.com/bitcoin/bitcoin/pull/11332

Sat, Feb 16, 02:41
markblundeberg added inline comments to D2322: remove minimum total fee option.
Sat, Feb 16, 02:22

Fri, Feb 15

markblundeberg removed a task from D2349: fix confusingly named function parameter 'scriptSig': T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.
Fri, Feb 15, 17:08
markblundeberg removed a revision from T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG: D2349: fix confusingly named function parameter 'scriptSig'.
Fri, Feb 15, 17:08
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG, a subtask of T526: Schnorr-ifying, as Resolved.
Fri, Feb 15, 03:48
markblundeberg closed T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG as Resolved.
Fri, Feb 15, 03:48
markblundeberg updated the diff for D2483: Schnorr signature activation.
  • add extra node for doing actual ban-checking (whitelist was stopping this)
  • include positive ban tests (for schnorr multisig)
  • get rid of update_block
Fri, Feb 15, 03:01

Thu, Feb 14

markblundeberg accepted D2542: Format BIP32 test cases manually.

Yeah that was hideous before ... linters aren't always right. :-D

Thu, Feb 14, 17:34
markblundeberg added a comment to D2554: CONTRIBUTING.md : recommend ccache.

Not 100% sure about the placement of this, but I think it does deserve to go *somewhere*.

Thu, Feb 14, 17:31
Herald added a reviewer for D2554: CONTRIBUTING.md : recommend ccache: deadalnix.
Thu, Feb 14, 17:30
markblundeberg accepted D2547: Merge #12366: http: Join worker threads before deleting work queue.

A nice simplification and improvement. Presumably there is no chance that StopHTTPServer will be called during StartHTTPServer execution, as they are only ever called from a particular thread?

Thu, Feb 14, 06:08
markblundeberg accepted D2545: qt: Poll ShutdownTimer after init is done.
Thu, Feb 14, 05:30
markblundeberg updated the diff for D2548: fix abc-parkedchain timeouts.

use wait_for_tip instead of sync_blocks

Thu, Feb 14, 05:21
markblundeberg updated the summary of D2548: fix abc-parkedchain timeouts.
Thu, Feb 14, 04:25
markblundeberg added a comment to D2548: fix abc-parkedchain timeouts.

Check out the debug logs.

Thu, Feb 14, 04:21
Herald added a reviewer for D2548: fix abc-parkedchain timeouts: deadalnix.
Thu, Feb 14, 04:14
markblundeberg updated the test plan for D2483: Schnorr signature activation.
Thu, Feb 14, 02:15
markblundeberg updated the diff for D2483: Schnorr signature activation.

various:

  • rebase on now-landed D2479 (+ address conflicts in overlap)
  • now fully mock-timed
  • added actual mininode testing of non-banning (borrowed from D2479)
  • added a reorg test at end, for good measure
  • nits
Thu, Feb 14, 02:13
markblundeberg added a child revision for D2527: Improved mempool handling when changing validation rulesets: D2483: Schnorr signature activation.
Thu, Feb 14, 02:13
markblundeberg planned changes to D2483: Schnorr signature activation.
Thu, Feb 14, 00:17

Wed, Feb 13

markblundeberg updated subscribers of D2544: Improve shutdown process.

@dagurval points out, maybe we want to go straight for https://github.com/bitcoin/bitcoin/pull/14670 ... sounds like this exits uncleanly in some cases?

Wed, Feb 13, 22:03
markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 21:57
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

some tiny nits that @Fabien pointed out on D2483 / D2527

Wed, Feb 13, 21:55
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.
  • fully mock test time
  • one more sendrawtransaction rejection test
  • misc changes
Wed, Feb 13, 21:49
markblundeberg added a child revision for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY: D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 21:49
markblundeberg added a child revision for D2527: Improved mempool handling when changing validation rulesets: D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 21:49
markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 17:45
markblundeberg added inline comments to D2483: Schnorr signature activation.
Wed, Feb 13, 17:42
markblundeberg added inline comments to D2483: Schnorr signature activation.
Wed, Feb 13, 17:42
markblundeberg added inline comments to D2483: Schnorr signature activation.
Wed, Feb 13, 17:36
markblundeberg removed parent revisions for D2479: Add activation code for SEGWIT_RECOVERY: D2527: Improved mempool handling when changing validation rulesets, D2506: Update mandatory flags after Magnetic anomaly has activated, D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Wed, Feb 13, 16:37
markblundeberg removed a child revision for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY: D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 16:37
markblundeberg removed a child revision for D2506: Update mandatory flags after Magnetic anomaly has activated: D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 16:37
markblundeberg removed a child revision for D2527: Improved mempool handling when changing validation rulesets: D2479: Add activation code for SEGWIT_RECOVERY.
Wed, Feb 13, 16:37
markblundeberg removed a parent revision for D2483: Schnorr signature activation: D2527: Improved mempool handling when changing validation rulesets.
Wed, Feb 13, 16:37
markblundeberg removed a child revision for D2527: Improved mempool handling when changing validation rulesets: D2483: Schnorr signature activation.
Wed, Feb 13, 16:37
markblundeberg updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

rebase after D2527 landing

Wed, Feb 13, 16:36
markblundeberg commandeered D2479: Add activation code for SEGWIT_RECOVERY.

commandeering this one for the home stretch

Wed, Feb 13, 16:35
markblundeberg updated the diff for D2483: Schnorr signature activation.

rebase after D2527 landing

Wed, Feb 13, 16:28
markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

last nit for % formatting

Wed, Feb 13, 15:01
markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address jason comments

Wed, Feb 13, 00:32

Tue, Feb 12

markblundeberg updated the diff for D2527: Improved mempool handling when changing validation rulesets.

address requests for change:

  • misc nits
  • logging messages altered
  • test now fully mock-timed
  • expanded comments about how transactions are tracked in invalidateblock and reorg events
Tue, Feb 12, 20:14
markblundeberg commandeered D2527: Improved mempool handling when changing validation rulesets.

Gonna take control of this as florian will be away for the next few days, and this needs landing soon. Thanks for the hard work thus far @florian . :-D

Tue, Feb 12, 17:54
markblundeberg updated subscribers of D2539: nits in abc-replay-protection.

@Fabien ping

Tue, Feb 12, 16:08
Herald added a reviewer for D2539: nits in abc-replay-protection: deadalnix.
Tue, Feb 12, 16:07
markblundeberg updated the diff for D2483: Schnorr signature activation.

fix nits that Fabien pointed out

Tue, Feb 12, 15:18
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Tue, Feb 12, 02:57
markblundeberg added inline comments to D2483: Schnorr signature activation.
Tue, Feb 12, 00:34
markblundeberg updated the diff for D2483: Schnorr signature activation.

rebased; shorten comment

Tue, Feb 12, 00:34
markblundeberg added a comment to D2376: Bump automatic replay protection to Nov 2019 upgrade.

(make check and all functional tests passed on my local machine as well)

Tue, Feb 12, 00:13

Mon, Feb 11

markblundeberg updated the summary of D2376: Bump automatic replay protection to Nov 2019 upgrade.
Mon, Feb 11, 23:30
markblundeberg updated the diff for D2376: Bump automatic replay protection to Nov 2019 upgrade.

rebased ; release notes now applied to 0.19.0

Mon, Feb 11, 23:29
markblundeberg commandeered D2376: Bump automatic replay protection to Nov 2019 upgrade.

I'm gonna grab this just to make sure it can get landed soon. Sorry for barging in!

Mon, Feb 11, 23:24
markblundeberg added inline comments to D2506: Update mandatory flags after Magnetic anomaly has activated.
Mon, Feb 11, 01:56
markblundeberg added a comment to D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.

@Fabien are these still on the table for 0.19?

Mon, Feb 11, 01:34

Sun, Feb 10

markblundeberg added a comment to D2527: Improved mempool handling when changing validation rulesets.

Looks good on the functional test, you even did "Send post-fork-only txn into the mempool again" 👍

Sun, Feb 10, 21:25
markblundeberg updated the test plan for D2483: Schnorr signature activation.
Sun, Feb 10, 17:39
markblundeberg accepted D2525: Add importMempool.
Sun, Feb 10, 17:17
markblundeberg updated the diff for D2483: Schnorr signature activation.

address comments; fix up variable names

Sun, Feb 10, 17:16
markblundeberg added inline comments to D2483: Schnorr signature activation.
Sun, Feb 10, 06:05
markblundeberg added inline comments to D2483: Schnorr signature activation.
Sun, Feb 10, 05:53
markblundeberg added inline comments to D2534: [schnorr] Add features to combine public keys in order to do musig..
Sun, Feb 10, 00:42
markblundeberg added inline comments to D2534: [schnorr] Add features to combine public keys in order to do musig..
Sun, Feb 10, 00:38

Sat, Feb 9

markblundeberg added a comment to D2534: [schnorr] Add features to combine public keys in order to do musig..

Quick comment for now, I'd like to take a closer look later.

Sat, Feb 9, 21:50
markblundeberg accepted D2376: Bump automatic replay protection to Nov 2019 upgrade.

Looks like this is ready to go -- just return it for review from the comment Action menu.

Sat, Feb 9, 19:27
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Sat, Feb 9, 18:33
markblundeberg accepted D2508: [tests] nulldummy cleanup.

ok; addressed my comments

Sat, Feb 9, 18:30
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Sat, Feb 9, 13:55
markblundeberg accepted D2527: Improved mempool handling when changing validation rulesets.
Sat, Feb 9, 04:03
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Sat, Feb 9, 01:02
markblundeberg retitled D2483: Schnorr signature activation from [Target v0.19] Schnorr signature activation to Schnorr signature activation.
Sat, Feb 9, 00:47
markblundeberg updated the summary of D2483: Schnorr signature activation.
Sat, Feb 9, 00:47
markblundeberg updated the summary of D2483: Schnorr signature activation.
Sat, Feb 9, 00:46
markblundeberg edited parent revisions for D2483: Schnorr signature activation, added: 1; removed: 2.
Sat, Feb 9, 00:45
markblundeberg removed a child revision for D2455: Enable Schnorr signature verification in CHECK(DATA)SIG(VERIFY): D2483: Schnorr signature activation.
Sat, Feb 9, 00:45
markblundeberg added a child revision for D2527: Improved mempool handling when changing validation rulesets: D2483: Schnorr signature activation.
Sat, Feb 9, 00:45
markblundeberg removed a child revision for D2487: add Schnorr signing implementation to test_framework: D2483: Schnorr signature activation.
Sat, Feb 9, 00:45
markblundeberg updated the diff for D2483: Schnorr signature activation.

(oops -- my renaming in an earlier rev had renamed too many things)

Sat, Feb 9, 00:43
markblundeberg updated the diff for D2483: Schnorr signature activation.

rebased onto D2527 using its mempool mechanics

Sat, Feb 9, 00:39
markblundeberg added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Sat, Feb 9, 00:27

Fri, Feb 8

markblundeberg abandoned D2487: add Schnorr signing implementation to test_framework.

ok, i liked the other one better anyway

Fri, Feb 8, 23:35
markblundeberg added inline comments to D2525: Add importMempool.
Fri, Feb 8, 20:31
markblundeberg updated subscribers of D2341: Enforce NULLDUMMY.
Fri, Feb 8, 17:05
markblundeberg planned changes to D2483: Schnorr signature activation.

@florian is working on a new system for the mempool reprocessing. This diff will benefit from that.

Fri, Feb 8, 15:34
markblundeberg accepted D2517: Revert "Merge #10712: Add change output if necessary to reduce excess fee".

Yikes -- seems like no harm in reverting if it was good before.

Fri, Feb 8, 03:58
Herald added a reviewer for D2516: Add address_cashaddr/address_legacy to validateaddress output: deadalnix.
Fri, Feb 8, 03:22
markblundeberg requested changes to D2508: [tests] nulldummy cleanup.

OK, just one more change needed really but indeed I suppose it looks cleaner.

Fri, Feb 8, 02:46
markblundeberg added a task to D2515: script_tests signature function renames to add "ECDSA": T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.
Fri, Feb 8, 00:33
markblundeberg added a revision to T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG: D2515: script_tests signature function renames to add "ECDSA".
Fri, Feb 8, 00:33
Herald added a reviewer for D2515: script_tests signature function renames to add "ECDSA": deadalnix.
Fri, Feb 8, 00:32

Thu, Feb 7

markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Thu, Feb 7, 23:57
markblundeberg updated the summary of D2483: Schnorr signature activation.
Thu, Feb 7, 23:52
markblundeberg accepted D2514: Move replay protection mempool management in ConnectTip.

Change in the right direction with good tests.

Thu, Feb 7, 23:46
markblundeberg added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Thu, Feb 7, 23:20