Page MenuHomePhabricator

[mining] Track a modified fees field.
Needs RevisionPublic

Authored by schancel on May 31 2019, 04:07.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Currently, the mempool tracks fees that were manually set by miners using the rpc interface.
These values are not added to CBlockTemplateEntry currently, as they are not used for anything
outside of prioritizing transactions.

However, future commits will move from using the MempoolEntry for adding transactions into a block
and directly use CBlockTemplateEntry. So, we need to track modified fees there as well for sorting purposes.
The primary field (txFee) is left alone, as it's sum must + reward must be a valid coinbase output value.

Depends on D2865

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chains-for-real4-5 (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6109
Build 10266: Bitcoin ABC Buildbot (legacy)
Build 10265: arc lint + arc unit