Page MenuHomePhabricator

[mining] Add package accounting functions to CBlockTemplateEntry
Needs RevisionPublic

Authored by schancel on Apr 23 2019, 01:17.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Add a private function to allow for BlockAssembler to properly
account for package information in CBlockTemplateEntry

Depends on D2863

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chains-for-real3 (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6107
Build 10262: Bitcoin ABC Teamcity Staging
Build 10261: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 23 2019, 01:17
Owners added a reviewer: Restricted Owners Package.Apr 23 2019, 01:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 01:17
jasonbcox requested changes to this revision.May 9 2019, 21:16
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/miner.h
58 ↗(On Diff #8228)

Why not just min(CFeeRate(...), CFeeRate(...))?

67 ↗(On Diff #8228)

A tx with 10000 parent txs all of order 0 will be order 1. This means order seems to be tracking max-depth of its parents rather than an approximation of number of dependencies. Is that right?

This revision now requires changes to proceed.May 9 2019, 21:16
schancel added inline comments.May 10 2019, 00:48
src/miner.h
58 ↗(On Diff #8228)

CFeeRate uses division.

67 ↗(On Diff #8228)

Yeah, it's not the number of dependencies unless it's a linear chain, but in some cases it won't be the number of dependencies even for that. I don't have a better definition of it.

The basic idea is that if sorted by Order the list would be ~ topologically valid. The idea is that transactions of lower order should go in before higher order ones.

schancel added inline comments.May 10 2019, 00:49
src/miner.h
67 ↗(On Diff #8228)

Another word that might describe it appropriately would be Rank

schancel updated this revision to Diff 9026.May 31 2019, 03:53

Rebase with a test

schancel updated this revision to Diff 9066.Jun 2 2019, 07:24

Fix comments

jasonbcox requested changes to this revision.Fri, Jun 21, 22:00
This revision now requires changes to proceed.Fri, Jun 21, 22:00