[mining] Add package accounting functions to CBlockTemplateEntry
Needs RevisionPublic
Actions

Authored by schancel on Apr 23 2019, 01:17.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Add a private function to allow for BlockAssembler to properly
account for package information in CBlockTemplateEntry

Depends on D2863

Test Plan

make check

Repository

rABC Bitcoin ABC

Branch

chains-for-real3 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5570
Build 9202: Bitcoin ABC Buildbot (legacy)
Build 9201: arc lint + arc unit

Owners added a reviewer: Restricted Owners Package.Apr 23 2019, 01:17

jasonbcox requested changes to this revision.May 9 2019, 21:16

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/miner.h
58	Why not just `min(CFeeRate(...), CFeeRate(...))`?
67	A tx with 10000 parent txs all of order 0 will be order 1. This means order seems to be tracking max-depth of its parents rather than an approximation of number of dependencies. Is that right?

This revision now requires changes to proceed.May 9 2019, 21:16

src/miner.h
58	CFeeRate uses division.
67	Yeah, it's not the number of dependencies unless it's a linear chain, but in some cases it won't be the number of dependencies even for that. I don't have a better definition of it. The basic idea is that if sorted by `Order` the list would be ~ topologically valid. The idea is that transactions of lower order should go in before higher order ones.