Page MenuHomePhabricator

[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
ClosedPublic

Authored by schancel on Apr 22 2019, 01:23.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Summary

As per title. Remove extra string parameter that prematurely optimizes the RPC API.
This parameter is an opportunity to pass in a string which doesn't match the uint256
provided.

Also happens to be identical to Core PR 9801.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Apr 22 2019, 01:23
Owners added a reviewer: Restricted Owners Package.Apr 22 2019, 01:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 01:23
jasonbcox requested changes to this revision.Apr 22 2019, 17:40
jasonbcox added a subscriber: jasonbcox.

This is an existing Core PR. Please apply the entire backport: https://github.com/bitcoin/bitcoin/pull/9801/files

This revision now requires changes to proceed.Apr 22 2019, 17:40
schancel retitled this revision from [nit] Remove extraneous extra parameter to `CTxMemPool::PrioritiseTransaction` to [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.Apr 23 2019, 01:52
schancel edited the summary of this revision. (Show Details)
schancel updated this revision to Diff 8232.Apr 23 2019, 01:58

Make identical to core pr cited

Fabien accepted this revision.Apr 23 2019, 06:04
jasonbcox accepted this revision.Apr 24 2019, 22:59
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 24 2019, 23:00
This revision was automatically updated to reflect the committed changes.