[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
ClosedPublic
Actions

Authored by schancel on Apr 22 2019, 01:23.

Details

Reviewers

deadalnix
jasonbcox
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`

Summary

As per title. Remove extra string parameter that prematurely optimizes the RPC API.
This parameter is an opportunity to pass in a string which doesn't match the uint256
provided.

Also happens to be identical to Core PR 9801.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nit-prioritise-tx (branched from master)

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 5549
Build 9160: Bitcoin ABC Buildbot (legacy)
Build 9159: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 22 2019, 01:23

Owners added a reviewer: Restricted Owners Package.Apr 22 2019, 01:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 01:23

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5549: Diff 8197.Apr 22 2019, 01:37

This is an existing Core PR. Please apply the entire backport: https://github.com/bitcoin/bitcoin/pull/9801/files

This revision now requires changes to proceed.Apr 22 2019, 17:40

schancel retitled this revision from [nit] Remove extraneous extra parameter to `CTxMemPool::PrioritiseTransaction` to [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.Apr 23 2019, 01:52

schancel edited the summary of this revision. (Show Details)

Make identical to core pr cited

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5573: Diff 8232.Apr 23 2019, 02:12

Fabien accepted this revision.Apr 23 2019, 06:04

jasonbcox accepted this revision.Apr 24 2019, 22:59

jasonbcox edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Apr 24 2019, 23:00

Closed by commit rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel). · Explain WhyApr 25 2019, 05:53

This revision was automatically updated to reflect the committed changes.

schancel added a commit: rSTAGINGa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.Sep 19 2019, 14:52

Revision Contents
Changeset List

			Path	Packages
M			src/rpc/mining.cpp (4 lines)
M			src/txmempool.h (4 lines)
M			src/txmempool.cpp (5 lines)
M			src/validation.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	8197	78eda7b		Apr 22 2019, 01:23	★	★
Diff 2	8232	78eda7b	Make identical to core pr cited	Apr 23 2019, 01:58	★	★
Diff 3	8263	966fcf6	rABCa9acc46b47f0cb3f2e415d08563a2348008aa23f	Apr 25 2019, 05:53	★	★

Commit	Tree	Parents	Author	Summary	Date
8d56fabd7620	27afbfb28785	78eda7b0d3bb	Shammah Chancellor	[nit] Remove extraneous extra parameter to `CTxMemPool::PrioritiseTransaction` (Show More…)	Apr 22 2019, 01:14