Page MenuHomePhabricator

Remove unknown version warning from UpdateTip
Changes PlannedPublic

Authored by schancel on Apr 9 2019, 01:46.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project

Since Antminer S9s now are able to do overt asicboost, there are many unknown
versions on mainnet headers. This is triggering warnings in the debug.log and it
is not apparent that this is meaningful any longer. Additionally, the BIP9 code
has been removed for activating any softforks based on the version bits anyways.

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
remove-warning2 (branched from master)
Lint OK
No Unit Test Coverage
Build Status
Buildable 5420
Build 8902: Bitcoin ABC Teamcity Staging
Build 8901: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 9 2019, 01:46
Owners added a reviewer: Restricted Owners Package.Apr 9 2019, 01:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2019, 01:46
schancel planned changes to this revision.Apr 9 2019, 02:03

This should in principle work on master now, once rebased...