Page MenuHomePhabricator

Remove unknown version warning from UpdateTip
ClosedPublic

Authored by markblundeberg on Apr 9 2019, 01:46.

Details

Summary

Since Antminer S9s now are able to do overt asicboost, there are many unknown
versions on mainnet headers. This is triggering warnings in the debug.log and it
is not apparent that this is meaningful any longer. Additionally, the BIP9 code
has been removed for activating any softforks based on the version bits anyways.

Depends on D3381

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Apr 9 2019, 01:46
Owners added a reviewer: Restricted Owners Package.Apr 9 2019, 01:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2019, 01:46
schancel planned changes to this revision.Apr 9 2019, 02:03

This should in principle work on master now, once rebased...

markblundeberg commandeered this revision.Jun 21 2019, 17:56
markblundeberg added a reviewer: schancel.
markblundeberg edited the summary of this revision. (Show Details)

rebased (part of this is now already done, in D3181)

markblundeberg added inline comments.Jun 21 2019, 18:30
src/validation.cpp
2144 ↗(On Diff #9573)

note that VERSIONBITS_LAST_OLD_BLOCK_VERSION, like other constants in versionbits.h, is unused now.

(only VERSIONBITS_TOP_BITS remains used)

jasonbcox requested changes to this revision.Jun 21 2019, 22:06

Depends on itself?

This revision now requires changes to proceed.Jun 21 2019, 22:06
markblundeberg requested review of this revision.Jun 21 2019, 22:57
markblundeberg added a comment.EditedJun 21 2019, 23:05

Note backports are basically caught up on this part of the code, except weak overlap with the incomplete parts of D1972, and some linting-related stuff in #12891 (which it looks like will we cannot take as-is due to code style differences).

Fabien accepted this revision.Jun 24 2019, 06:32
jasonbcox accepted this revision.Jun 24 2019, 18:32
This revision is now accepted and ready to land.Jun 24 2019, 18:32

simple rebase