Page MenuHomePhabricator
Differential D2788

Remove unknown version warning from UpdateTip
ClosedPublic
Actions

Authored by markblundeberg on Apr 9 2019, 01:46.

Details

Reviewers
deadalnix
schancel
jasonbcox
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1ae9292bfca3: Remove unknown version warning from UpdateTip
rABC1ae9292bfca3: Remove unknown version warning from UpdateTip
Summary

Since Antminer S9s now are able to do overt asicboost, there are many unknown
versions on mainnet headers. This is triggering warnings in the debug.log and it
is not apparent that this is meaningful any longer. Additionally, the BIP9 code
has been removed for activating any softforks based on the version bits anyways.

Depends on D3381

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-warning2 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5420
Build 8902: Bitcoin ABC Buildbot (legacy)
Build 8901: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 9 2019, 01:46
Owners added a reviewer: Restricted Owners Package.Apr 9 2019, 01:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2019, 01:46
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 9 2019, 01:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 9 2019, 01:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B5420: Diff 8008!Apr 9 2019, 01:59
schancel planned changes to this revision.Apr 9 2019, 02:03
markblundeberg awarded a token.Jun 3 2019, 14:37
markblundeberg mentioned this in D3181: Merge #15471: rpc/gui: Remove 'Unknown block versions being mined' warning.
markblundeberg added a subscriber: markblundeberg.Jun 13 2019, 01:43

This should in principle work on master now, once rebased...

markblundeberg mentioned this in D3381: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency.Jun 21 2019, 17:48
markblundeberg commandeered this revision.Jun 21 2019, 17:56
markblundeberg added a reviewer: schancel.
markblundeberg updated this revision to Diff 9573.Jun 21 2019, 18:07
markblundeberg edited the summary of this revision. (Show Details)

rebased (part of this is now already done, in D3181)

teamcity added a comment.Jun 21 2019, 18:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added reviewers: jasonbcox, Fabien.Jun 21 2019, 18:11
Harbormaster completed remote builds in B6433: Diff 9573.Jun 21 2019, 18:13
teamcity added a comment.Jun 21 2019, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg added inline comments.Jun 21 2019, 18:30
src/validation.cpp
2144 ↗(On Diff #9573)

note that VERSIONBITS_LAST_OLD_BLOCK_VERSION, like other constants in versionbits.h, is unused now.

(only VERSIONBITS_TOP_BITS remains used)

jasonbcox requested changes to this revision.Jun 21 2019, 22:06

Depends on itself?

This revision now requires changes to proceed.Jun 21 2019, 22:06
markblundeberg edited the summary of this revision. (Show Details)Jun 21 2019, 22:56
markblundeberg added a parent revision: D3381: Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency.
In D2788#80068, @jasonbcox wrote:

Depends on itself?

*face palms*

markblundeberg requested review of this revision.Jun 21 2019, 22:57
markblundeberg added a comment.EditedJun 21 2019, 23:05

Note backports are basically caught up on this part of the code, except weak overlap with the incomplete parts of D1972, and some linting-related stuff in #12891 (which it looks like will we cannot take as-is due to code style differences).

Fabien accepted this revision.Jun 24 2019, 06:32
jasonbcox accepted this revision.Jun 24 2019, 18:32
This revision is now accepted and ready to land.Jun 24 2019, 18:32
markblundeberg mentioned this in D1554: Remove warning about block version..Jun 24 2019, 18:34
markblundeberg updated this revision to Diff 9637.Jun 25 2019, 02:38

simple rebase

teamcity added a comment.Jun 25 2019, 02:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 25 2019, 02:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6470: Diff 9637.Jun 25 2019, 02:45
Closed by commit rABC1ae9292bfca3: Remove unknown version warning from UpdateTip (authored by schancel, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 25 2019, 02:56
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC1ae9292bfca3: Remove unknown version warning from UpdateTip.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING1ae9292bfca3: Remove unknown version warning from UpdateTip.Sep 19 2019, 00:30

Revision Contents
Changeset List

PathSize
src/
44 lines

Diff 8008

View Options

src/validation.cpp

Loading...