Page MenuHomePhabricator

[Part 5 of 5] Add a CChainState class to clarify internal interfaces
ClosedPublic

Authored by jasonbcox on Oct 24 2018, 18:51.

Details

Summary

Move some additional variables into CChainState private

Backport of Core PR 10279 commit 2862aca
https://github.com/bitcoin/bitcoin/pull/10279/commits/2862aca40f24acc48d3052d5ba3f639e3fc0a621

Depends on D1971 and D2645
T572

Test Plan
make check
test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Oct 24 2018, 18:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:51
schancel planned changes to this revision.Oct 26 2018, 22:48
jasonbcox edited the summary of this revision. (Show Details)Apr 2 2019, 20:34
markblundeberg edited the summary of this revision. (Show Details)Jun 21 2019, 17:25
markblundeberg added a subscriber: markblundeberg.

What about the UpdateTip changes?

jasonbcox commandeered this revision.Jul 16 2019, 02:14
jasonbcox added a reviewer: schancel.
jasonbcox updated this revision to Diff 10310.Jul 16 2019, 02:59
  • Rebase
  • Fix missing portions of the backport
jasonbcox edited the test plan for this revision. (Show Details)Jul 16 2019, 02:59
deadalnix accepted this revision.Sun, Jul 21, 13:36
This revision is now accepted and ready to land.Sun, Jul 21, 13:36