Page MenuHomePhabricator

[Part 1 of 5] Add a CChainState class to clarify internal interfaces
ClosedPublic

Authored by schancel on Oct 24 2018, 18:49.

Details

Summary

Move txindex/undo data disk location stuff out of ConnectBlock

Backport of Core PR10279 commit 50701ba

Test Plan
make VERBOSE=1 check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Oct 24 2018, 18:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:49
jasonbcox accepted this revision.Oct 24 2018, 19:31
This revision is now accepted and ready to land.Oct 24 2018, 19:31
deadalnix requested changes to this revision.Oct 24 2018, 20:43
deadalnix added a subscriber: deadalnix.

Please edit the description message to have PR10279 instead of in two words so that's easy to grep for.

src/validation.cpp
1458 ↗(On Diff #5523)

Braces.

1482 ↗(On Diff #5523)

dito

1483 ↗(On Diff #5523)

dito

This revision now requires changes to proceed.Oct 24 2018, 20:43
schancel edited the summary of this revision. (Show Details)Oct 24 2018, 22:16
schancel updated this revision to Diff 5529.Oct 24 2018, 22:17

Add bra-kets

deadalnix requested changes to this revision.Oct 24 2018, 22:47
deadalnix added inline comments.
src/validation.cpp
1746 ↗(On Diff #5529)

Why does this stays ?

1755 ↗(On Diff #5529)

dito

This revision now requires changes to proceed.Oct 24 2018, 22:47
deadalnix added inline comments.Oct 24 2018, 22:56
src/validation.cpp
1455 ↗(On Diff #5529)

braces

deadalnix added inline comments.Oct 24 2018, 22:57
src/validation.cpp
1479 ↗(On Diff #5529)

GetId

schancel updated this revision to Diff 5530.Oct 25 2018, 00:49

Remove stray unused variables

deadalnix requested changes to this revision.Oct 25 2018, 22:11
deadalnix added inline comments.
src/validation.cpp
1455 ↗(On Diff #5530)

braces

This revision now requires changes to proceed.Oct 25 2018, 22:11
schancel planned changes to this revision.Oct 26 2018, 22:47
schancel requested review of this revision.Sun, Nov 25, 17:47
deadalnix accepted this revision.Thu, Nov 29, 00:52
This revision is now accepted and ready to land.Thu, Nov 29, 00:52
Closed by commit rABC007da3b2780f: [Part 1 of 5] Add a CChainState class to clarify internal interfaces (authored by Matt Corallo <git@bluematt.me>, committed by schancel). · Explain WhyThu, Nov 29, 21:10
This revision was automatically updated to reflect the committed changes.