Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING62cbf381851b: Merge #11838: qa: Add getrawtransaction in_active_chain=False test
rABC62cbf381851b: Merge #11838: qa: Add getrawtransaction in_active_chain=False test

Summary

fa4c16d qa: Add getrawtransaction in_active_chain=False test (MarcoFalke)

Pull request description:

#10275 accidentally forgot to add a test for `in_active_chain==False`.

This adds a test and also removes the special casing of `blockhash.IsNull()`, which makes no sense imo.

Tree-SHA512: 6c51295820b3dcd53b0b48020ab2b8c8f5864cd5061ddab2b35d35d643eb3e60ef95ff20c06c985a2e47f7080e82f27f3e00ee61c85dce627776d5ea6febee8f

Backport of Core PR 11838
https://github.com/bitcoin/bitcoin/pull/11838/files
Completes T593

Test Plan

make check
test_runner.py rpc_rawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Apr 13 2019, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 13 2019, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D2793: Merge #11041: Add LookupBlockIndex.Apr 13 2019, 16:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5447: Diff 8046.Apr 13 2019, 16:16

Fabien accepted this revision.Apr 14 2019, 06:10

This revision is now accepted and ready to land.Apr 14 2019, 06:10

Closed by commit rABC62cbf381851b: Merge #11838: qa: Add getrawtransaction in_active_chain=False test (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyApr 14 2019, 17:16

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING62cbf381851b: Merge #11838: qa: Add getrawtransaction in_active_chain=False test.Sep 18 2019, 22:57

Merge #11838: qa: Add getrawtransaction in_active_chain=False test
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 8051

src/rpc/rawtransaction.cpp

test/functional/rpc_rawtransaction.py

Merge #11838: qa: Add getrawtransaction in_active_chain=False testClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8051

src/rpc/rawtransaction.cpp

test/functional/rpc_rawtransaction.py

Merge #11838: qa: Add getrawtransaction in_active_chain=False test
ClosedPublic
Actions

Revision Contents
Changeset List