Page MenuHomePhabricator

Merge #11838: qa: Add getrawtransaction in_active_chain=False test
ClosedPublic

Authored by jasonbcox on Sat, Apr 13, 16:00.

Details

Summary

fa4c16d qa: Add getrawtransaction in_active_chain=False test (MarcoFalke)

Pull request description:

#10275 accidentally forgot to add a test for `in_active_chain==False`.

This adds a test and also removes the special casing of `blockhash.IsNull()`, which makes no sense imo.

Tree-SHA512: 6c51295820b3dcd53b0b48020ab2b8c8f5864cd5061ddab2b35d35d643eb3e60ef95ff20c06c985a2e47f7080e82f27f3e00ee61c85dce627776d5ea6febee8f

Backport of Core PR 11838
https://github.com/bitcoin/bitcoin/pull/11838/files
Completes T593

Test Plan

make check
test_runner.py rpc_rawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Sat, Apr 13, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 13, 16:00
Fabien accepted this revision.Sun, Apr 14, 06:10
This revision is now accepted and ready to land.Sun, Apr 14, 06:10
This revision was automatically updated to reflect the committed changes.