Page MenuHomePhabricator

[Part 2 of 5] Add a CChainState class to clarify internal interfaces

Authored by jasonbcox on Oct 24 2018, 18:50.



Move block writing out of AcceptBlock

Backport of Core PR 10279 commit e104f0f
Depends on D1968
Progress towards T572

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Rebase, remove excess whitespace change

jasonbcox requested changes to this revision.Nov 30 2018, 22:43
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
3176 ↗(On Diff #6183)

Missing lines from e104f0f

3879 ↗(On Diff #6183)

is this equivalent to return false; as in the original PR?

4815 ↗(On Diff #6183)

This line was moved in the original PR

This revision now requires changes to proceed.Nov 30 2018, 22:43
jasonbcox edited reviewers, added: schancel; removed: jasonbcox.
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)

Rebase + fixes described above

This revision is now accepted and ready to land.Mar 28 2019, 10:12
This revision was automatically updated to reflect the committed changes.