Page MenuHomePhabricator

[Part 2 of 5] Add a CChainState class to clarify internal interfaces

Authored by jasonbcox on Oct 24 2018, 18:50.



Move block writing out of AcceptBlock

Backport of Core PR 10279 commit e104f0f
Depends on D1968
Progress towards T572

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Lint OK
No Unit Test Coverage
Build Status
Buildable 4178
Build 6422: Bitcoin ABC Buildbot (legacy)
Build 6421: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 24 2018, 18:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:50
schancel planned changes to this revision.Oct 26 2018, 22:47
schancel requested review of this revision.Nov 29 2018, 21:50
schancel updated this revision to Diff 6183.Nov 29 2018, 21:57

Rebase, remove excess whitespace change

jasonbcox requested changes to this revision.Nov 30 2018, 22:43
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.

Missing lines from e104f0f


is this equivalent to return false; as in the original PR?


This line was moved in the original PR

This revision now requires changes to proceed.Nov 30 2018, 22:43
jasonbcox commandeered this revision.Mar 27 2019, 23:17
jasonbcox edited reviewers, added: schancel; removed: jasonbcox.
jasonbcox edited the summary of this revision. (Show Details)
jasonbcox edited the test plan for this revision. (Show Details)
jasonbcox updated this revision to Diff 7851.Mar 27 2019, 23:48

Rebase + fixes described above

jasonbcox edited the summary of this revision. (Show Details)Mar 27 2019, 23:48
Fabien accepted this revision.Mar 28 2019, 10:12
This revision is now accepted and ready to land.Mar 28 2019, 10:12
This revision was automatically updated to reflect the committed changes.