scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks
ClosedPublic
Actions

Authored by jasonbcox on Jul 18 2019, 17:28.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks
rABC26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks

Summary

To reflect its actual status as a member rather than a global value.

g_failed_blocks was previously global: 2862aca

-BEGIN VERIFY SCRIPT-
sed -i 's/g_failed_blocks/m_failed_blocks/g' src/validation.cpp
-END VERIFY SCRIPT-

Backport of Core PR13016
https://github.com/bitcoin/bitcoin/pull/13016/files
Completes T579

Depends on D1972

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jul 18 2019, 17:28

Herald added a reviewer: deadalnix. · View Herald TranscriptJul 18 2019, 17:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6885: Diff 10348.Jul 18 2019, 17:35

deadalnix accepted this revision.Jul 18 2019, 21:18

This revision is now accepted and ready to land.Jul 18 2019, 21:18

Closed by commit rABC26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (authored by jasonbcox). · Explain WhyJul 22 2019, 18:37

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.

jasonbcox added a commit: rSTAGING26b57a9147f5: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.Sep 19 2019, 01:21

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

14 lines

Diff 10381

View Options

scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocksClosedPublicActions