Page MenuHomePhabricator
Differential D11755

Fix outdated comments referring to ::ChainActive()
ClosedPublic
Actions

Authored by PiRK on Jul 15 2022, 11:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1b305875768a: Fix outdated comments referring to ::ChainActive()
Summary

Remove also a comment about g_chainstate.
The additional ::ChainActive comment removed in validation.cpp was missed in a backport in D1972.

This is a backport of core#23258

Test Plan
grep -r "::Chain\w*A" ../src/
grep -r "g_chainman" ../src/

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jul 15 2022, 11:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2022, 11:50
PiRK requested review of this revision.Jul 15 2022, 11:50
teamcity edited the summary of this revision. (Show Details)Jul 15 2022, 11:50
PiRK edited the test plan for this revision. (Show Details)Jul 15 2022, 11:52
PiRK edited the test plan for this revision. (Show Details)
Fabien accepted this revision.Jul 15 2022, 11:54
This revision is now accepted and ready to land.Jul 15 2022, 11:54
PiRK updated this revision to Diff 34393.Jul 15 2022, 11:56

fix also the last remaining reference to ChainstateActive() (this one is still unfixed in Core)

Harbormaster completed remote builds in B19647: Diff 34392.Jul 15 2022, 12:06
Harbormaster completed remote builds in B19648: Diff 34393.Jul 15 2022, 12:14
Closed by commit rABC1b305875768a: Fix outdated comments referring to ::ChainActive() (authored by Samuel Dobson <dobsonsa68@gmail.com>, committed by PiRK). · Explain WhyJul 15 2022, 13:12
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC1b305875768a: Fix outdated comments referring to ::ChainActive().

Revision Contents
Changeset List

PathSize
src/
index/
6 lines
6 lines
4 lines
3 lines
wallet/
2 lines

Diff 34394

View Options

src/index/base.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...