Page MenuHomePhabricator
Differential D9694

Ensure `nExtraNonce` is initialized randomly
AbandonedPublic
Actions

Authored by Fabien on Jun 23 2021, 04:42.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Currently, nExtraNonce is always initialized to zero
when mining a new block. However, this causes deterministic
nonces during functional and unit tests. In some cases, tests
which make use of the ABC block parking functionality will
mine two blocks on the same tip, with the same nonces. This
results in two blocks with the same hash, causing it to be
ignored when attempting to accept the block. The result of
this is that intentional reorgs in functional tests may not
occur when intended.

This commit changes the initialization of nExtraNonce to
be a random number so that no two calls to generatetoaddress
create identical blocks.

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nondeterministic-increment-extra-nonce (branched from master)
Lint
Lint Errors
SeverityLocationCodeMessage
Errortest/functional/rpc_blockchain.py:331F821flake8 F821
Unit
No Test Coverage
Build Status
Buildable 16071
Build 32029: Build Diffbuild-diff · build-without-wallet · build-clang · build-debug · lint-circular-dependencies · build-clang-tidy
Build 32028: arc lint + arc unit

Event Timeline

schancel created this revision.Jun 23 2021, 04:42
Owners added a reviewer: Restricted Owners Package.Jun 23 2021, 04:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 23 2021, 04:42
schancel requested review of this revision.Jun 23 2021, 04:42
Harbormaster completed remote builds in B16037: Diff 28953.Jun 23 2021, 04:58
teamcity added a comment.Jun 23 2021, 04:58
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T04:56:45.202000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_045525/rpc_dumptxoutset_397
2021-06-23T04:56:45.509000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(58b35e6d151b2811bda43cff899d483b27dc7975ef4e973ca984b39391503f02 == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T04:56:45.560000Z TestFramework (INFO): Stopping nodes
2021-06-23T04:56:45.862000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_045525/rpc_dumptxoutset_397
2021-06-23T04:56:45.862000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_045525/rpc_dumptxoutset_397/test_framework.log
2021-06-23T04:56:45.862000Z TestFramework (ERROR): 
2021-06-23T04:56:45.863000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_045525/rpc_dumptxoutset_397' to consolidate all logs
2021-06-23T04:56:45.863000Z TestFramework (ERROR): 
2021-06-23T04:56:45.863000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T04:56:45.864000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T04:56:45.864000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py

teamcity added a comment.Jun 23 2021, 05:12
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_blockchain.py ======

------- Stdout: -------
2021-06-23T05:09:39.543000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_blockchain_121
2021-06-23T05:09:40.092000Z TestFramework (INFO): Create some old blocks
2021-06-23T05:09:41.613000Z TestFramework (INFO): Test getblockchaininfo
2021-06-23T05:09:43.162000Z TestFramework (INFO): Test getchaintxstats
2021-06-23T05:09:43.253000Z TestFramework (INFO): Test that gettxoutsetinfo() works for blockchain with just the genesis block
2021-06-23T05:09:43.358000Z TestFramework (INFO): Test that gettxoutsetinfo() returns the same result after invalidate/reconsider block
2021-06-23T05:09:47.487000Z TestFramework (INFO): Test waitforblockheight
2021-06-23T05:09:47.711000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_blockchain.py", line 71, in run_test
    self._test_getblock()
  File "/work/test/functional/rpc_blockchain.py", line 392, in _test_getblock
    assert_equal(blockinfo['size'], 181)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(184 == 181)
2021-06-23T05:09:47.762000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:09:47.966000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_blockchain_121
2021-06-23T05:09:47.966000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_blockchain_121/test_framework.log
2021-06-23T05:09:47.966000Z TestFramework (ERROR): 
2021-06-23T05:09:47.966000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_blockchain_121' to consolidate all logs
2021-06-23T05:09:47.966000Z TestFramework (ERROR): 
2021-06-23T05:09:47.966000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:09:47.967000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:09:47.967000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T05:10:55.004000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_dumptxoutset_219
2021-06-23T05:10:55.732000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(294ae4c23601982a11021e2fa3baebf78e2f1bd1278cb771854100d245a54fdf == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T05:10:55.783000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:10:55.985000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_dumptxoutset_219
2021-06-23T05:10:55.985000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_dumptxoutset_219/test_framework.log
2021-06-23T05:10:55.985000Z TestFramework (ERROR): 
2021-06-23T05:10:55.986000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_050705/rpc_dumptxoutset_219' to consolidate all logs
2021-06-23T05:10:55.986000Z TestFramework (ERROR): 
2021-06-23T05:10:55.986000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:10:55.986000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:10:55.987000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_blockchain.py
Bitcoin ABC functional tests: rpc_dumptxoutset.py

teamcity added a comment.Jun 23 2021, 05:19
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_blockchain.py ======

------- Stdout: -------
2021-06-23T05:13:23.442000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_blockchain_426
2021-06-23T05:13:23.735000Z TestFramework (INFO): Create some old blocks
2021-06-23T05:13:24.915000Z TestFramework (INFO): Test getblockchaininfo
2021-06-23T05:13:25.953000Z TestFramework (INFO): Test getchaintxstats
2021-06-23T05:13:26.013000Z TestFramework (INFO): Test that gettxoutsetinfo() works for blockchain with just the genesis block
2021-06-23T05:13:26.116000Z TestFramework (INFO): Test that gettxoutsetinfo() returns the same result after invalidate/reconsider block
2021-06-23T05:13:30.445000Z TestFramework (INFO): Test waitforblockheight
2021-06-23T05:13:30.683000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_blockchain.py", line 71, in run_test
    self._test_getblock()
  File "/work/test/functional/rpc_blockchain.py", line 392, in _test_getblock
    assert_equal(blockinfo['size'], 181)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(184 == 181)
2021-06-23T05:13:30.736000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:13:30.941000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_blockchain_426
2021-06-23T05:13:30.941000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_blockchain_426/test_framework.log
2021-06-23T05:13:30.941000Z TestFramework (ERROR): 
2021-06-23T05:13:30.942000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_blockchain_426' to consolidate all logs
2021-06-23T05:13:30.942000Z TestFramework (ERROR): 
2021-06-23T05:13:30.942000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:13:30.943000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:13:30.943000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T05:14:31.083000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_dumptxoutset_524
2021-06-23T05:14:31.415000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(14d271aac181a67d053d22651c87f10a9895dc9c44e6bbe496f7f64079cd8d3a == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T05:14:31.466000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:14:32.122000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_dumptxoutset_524
2021-06-23T05:14:32.122000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_dumptxoutset_524/test_framework.log
2021-06-23T05:14:32.122000Z TestFramework (ERROR): 
2021-06-23T05:14:32.122000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051115/rpc_dumptxoutset_524' to consolidate all logs
2021-06-23T05:14:32.122000Z TestFramework (ERROR): 
2021-06-23T05:14:32.122000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:14:32.122000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:14:32.122000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: rpc_blockchain.py ======

------- Stdout: -------
2021-06-23T05:17:02.033000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_blockchain_124
2021-06-23T05:17:02.574000Z TestFramework (INFO): Create some old blocks
2021-06-23T05:17:03.395000Z TestFramework (INFO): Test getblockchaininfo
2021-06-23T05:17:04.636000Z TestFramework (INFO): Test getchaintxstats
2021-06-23T05:17:04.693000Z TestFramework (INFO): Test that gettxoutsetinfo() works for blockchain with just the genesis block
2021-06-23T05:17:04.761000Z TestFramework (INFO): Test that gettxoutsetinfo() returns the same result after invalidate/reconsider block
2021-06-23T05:17:08.438000Z TestFramework (INFO): Test waitforblockheight
2021-06-23T05:17:08.686000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_blockchain.py", line 71, in run_test
    self._test_getblock()
  File "/work/test/functional/rpc_blockchain.py", line 392, in _test_getblock
    assert_equal(blockinfo['size'], 181)
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(183 == 181)
2021-06-23T05:17:08.739000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:17:08.943000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_blockchain_124
2021-06-23T05:17:08.944000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_blockchain_124/test_framework.log
2021-06-23T05:17:08.944000Z TestFramework (ERROR): 
2021-06-23T05:17:08.944000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_blockchain_124' to consolidate all logs
2021-06-23T05:17:08.944000Z TestFramework (ERROR): 
2021-06-23T05:17:08.944000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:17:08.944000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:17:08.944000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T05:18:08.322000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_dumptxoutset_222
2021-06-23T05:18:08.639000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(65d5f9a29a7af96fa583daf603acfa757a25510affa51545802a1265fbadd4b3 == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T05:18:08.690000Z TestFramework (INFO): Stopping nodes
2021-06-23T05:18:08.791000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_dumptxoutset_222
2021-06-23T05:18:08.791000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_dumptxoutset_222/test_framework.log
2021-06-23T05:18:08.791000Z TestFramework (ERROR): 
2021-06-23T05:18:08.791000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_051443/rpc_dumptxoutset_222' to consolidate all logs
2021-06-23T05:18:08.791000Z TestFramework (ERROR): 
2021-06-23T05:18:08.791000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T05:18:08.791000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T05:18:08.791000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_blockchain.py
Bitcoin ABC functional tests: rpc_dumptxoutset.py
Bitcoin ABC functional tests with the next upgrade activated: rpc_blockchain.py
Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py

schancel updated this revision to Diff 28954.Jun 23 2021, 05:54

Fixes rpc_blockchain. It should have used assert_approx, but dependented on
the deterministic nature of the extra nonce.

Harbormaster completed remote builds in B16038: Diff 28954.Jun 23 2021, 05:54
schancel added a comment.Jun 23 2021, 05:55

Will look at the second test that's broken later.

teamcity added a comment.Jun 23 2021, 06:05
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T06:03:36.725000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_055937/rpc_dumptxoutset_701
2021-06-23T06:03:37.446000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(5c7cfad1a641c1ac958bbef525f50a075417fe09296ca6e1393549a98c66caac == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T06:03:37.497000Z TestFramework (INFO): Stopping nodes
2021-06-23T06:03:37.699000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_055937/rpc_dumptxoutset_701
2021-06-23T06:03:37.699000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_055937/rpc_dumptxoutset_701/test_framework.log
2021-06-23T06:03:37.699000Z TestFramework (ERROR): 
2021-06-23T06:03:37.699000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_  _20210623_055937/rpc_dumptxoutset_701' to consolidate all logs
2021-06-23T06:03:37.699000Z TestFramework (ERROR): 
2021-06-23T06:03:37.699000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T06:03:37.699000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T06:03:37.699000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py

teamcity added a comment.Jun 23 2021, 06:09
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T06:04:15.681000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060105/rpc_dumptxoutset_189
2021-06-23T06:04:16.290000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(14cc631651ae07ac5a1b12247cf308ba899b2518e048271a1403719dcd5c3e20 == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T06:04:16.341000Z TestFramework (INFO): Stopping nodes
2021-06-23T06:04:16.543000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060105/rpc_dumptxoutset_189
2021-06-23T06:04:16.543000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060105/rpc_dumptxoutset_189/test_framework.log
2021-06-23T06:04:16.543000Z TestFramework (ERROR): 
2021-06-23T06:04:16.544000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060105/rpc_dumptxoutset_189' to consolidate all logs
2021-06-23T06:04:16.544000Z TestFramework (ERROR): 
2021-06-23T06:04:16.544000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T06:04:16.545000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T06:04:16.545000Z TestFramework (ERROR):
====== Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T06:07:14.131000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060426/rpc_dumptxoutset_262
2021-06-23T06:07:14.436000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(34f90b38bdbe32d25e095fceb183eacb9047332b346ec58fabcddba65ea46085 == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T06:07:14.487000Z TestFramework (INFO): Stopping nodes
2021-06-23T06:07:14.639000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060426/rpc_dumptxoutset_262
2021-06-23T06:07:14.639000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060426/rpc_dumptxoutset_262/test_framework.log
2021-06-23T06:07:14.639000Z TestFramework (ERROR): 
2021-06-23T06:07:14.639000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_  _20210623_060426/rpc_dumptxoutset_262' to consolidate all logs
2021-06-23T06:07:14.639000Z TestFramework (ERROR): 
2021-06-23T06:07:14.639000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T06:07:14.640000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T06:07:14.640000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py
Bitcoin ABC functional tests with the next upgrade activated: rpc_dumptxoutset.py

teamcity added a comment.Jun 23 2021, 06:21
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: rpc_dumptxoutset.py ======

------- Stdout: -------
2021-06-23T06:20:34.182000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_061915/rpc_dumptxoutset_483
2021-06-23T06:20:34.486000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 127, in main
    self.run_test()
  File "/work/test/functional/rpc_dumptxoutset.py", line 38, in run_test
    '65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b')
  File "/work/test/functional/test_framework/util.py", line 60, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not(73053ebc2c6c09a04955346b8f5a32effd4f9767f345a60bb57cdad53b28c7eb == 65d0aec2439aae14373c153f596fb90a87b643d9bff3e65f250aa8f055e6816b)
2021-06-23T06:20:34.537000Z TestFramework (INFO): Stopping nodes
2021-06-23T06:20:34.840000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_061915/rpc_dumptxoutset_483
2021-06-23T06:20:34.840000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_061915/rpc_dumptxoutset_483/test_framework.log
2021-06-23T06:20:34.840000Z TestFramework (ERROR): 
2021-06-23T06:20:34.841000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20210623_061915/rpc_dumptxoutset_483' to consolidate all logs
2021-06-23T06:20:34.841000Z TestFramework (ERROR): 
2021-06-23T06:20:34.841000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2021-06-23T06:20:34.842000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2021-06-23T06:20:34.842000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: rpc_dumptxoutset.py

majcosta mentioned this in D9697: make nExtraNonce static to IncrementExtraNonce.Jun 24 2021, 08:40
deadalnix requested changes to this revision.Jun 24 2021, 11:35
deadalnix added a subscriber: deadalnix.

Back on your queue, this seems to be breaking tests.

This revision now requires changes to proceed.Jun 24 2021, 11:35
schancel updated this revision to Diff 29003.Jun 29 2021, 01:32

Removing deterministic check on txout dump. Does not seem to be
testable given that block hashes and txout hashes are no longer
deterministic on regtest.

Harbormaster completed remote builds in B16071: Diff 29003.Jun 29 2021, 01:32
Fabien commandeered this revision.Jun 10 2023, 19:22
Fabien abandoned this revision.
Fabien added a reviewer: schancel.

Revision Contents
Changeset List

PathSize
src/
3 lines
test/
functional/
3 lines
15 lines

Diff 29003

View Options

src/miner.cpp

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...
View Options

test/functional/rpc_dumptxoutset.py

Loading...