Changeset View
Changeset View
Standalone View
Standalone View
src/miner.h
Show All 20 Lines | |||||
class CReserveKey; | class CReserveKey; | ||||
class CScript; | class CScript; | ||||
class CWallet; | class CWallet; | ||||
static const bool DEFAULT_PRINTPRIORITY = false; | static const bool DEFAULT_PRINTPRIORITY = false; | ||||
struct CBlockTemplateEntry { | struct CBlockTemplateEntry { | ||||
CTransactionRef tx; | CTransactionRef tx; | ||||
Amount fees; | //!< Total real fees paid by the transaction and cached to avoid parent | ||||
int64_t sigOpCount; | //!< lookup | ||||
jasonbcox: Why rename these? it will only make backports more difficult with no benefit. | |||||
schancelAuthorUnsubmitted Done Inline ActionsThis code is unique to ABC. It was written to deal with CTOR sorts. schancel: This code is unique to ABC. It was written to deal with CTOR sorts. | |||||
jasonbcoxUnsubmitted Not Done Inline Actionsok jasonbcox: ok | |||||
jasonbcoxUnsubmitted Not Done Inline ActionsThe code seems to indicate that this actually negative total fees. The comment should indicate this. jasonbcox: The code seems to indicate that this actually negative total fees. The comment should indicate… | |||||
schancelAuthorUnsubmitted Done Inline ActionsThey're not negative. schancel: They're not negative. | |||||
jasonbcoxUnsubmitted Not Done Inline ActionsThe code below has multiple places where txFees is negative and I can't find anywhere they are actually positive values. jasonbcox: The code below has multiple places where txFees is negative and I can't find anywhere they are… | |||||
schancelAuthorUnsubmitted Done Inline ActionsWhich code below? There is no code below that assumes these are negative. If you're talking about: pblocktemplate->entries.emplace_back(CTransactionRef(), -SATOSHI, 0, -1); That's because they're supposed to be out of bounds. schancel: Which code below? There is no code below that assumes these are negative. If you're talking… | |||||
Amount txFee; | |||||
CBlockTemplateEntry(CTransactionRef _tx, Amount _fees, int64_t _sigOpCount) | //!< Cached total size of the transaction to avoid reserializing transaction | ||||
: tx(_tx), fees(_fees), sigOpCount(_sigOpCount){}; | size_t txSize; | ||||
//!< Cached total number of SigOps | |||||
uint64_t txSigOps; | |||||
CBlockTemplateEntry(CTransactionRef _tx, Amount _fees, uint64_t _size, | |||||
int64_t _sigOps) | |||||
: tx(_tx), txFee(_fees), txSize(_size), txSigOps(_sigOps) {} | |||||
}; | }; | ||||
struct CBlockTemplate { | struct CBlockTemplate { | ||||
CBlock block; | CBlock block; | ||||
std::vector<CBlockTemplateEntry> entries; | std::vector<CBlockTemplateEntry> entries; | ||||
}; | }; | ||||
▲ Show 20 Lines • Show All 196 Lines • Show Last 20 Lines |
Why rename these? it will only make backports more difficult with no benefit.