Page MenuHomePhabricator
Differential D3253 Diff 9239 src/script/interpreter.cpp

Changeset View

Standalone View

View Options

src/script/interpreter.cpp

Show First 20 Lines • Show All 1,455 Lines • ▼ Show 20 Linesuint256 SignatureHash(const CScript &scriptCode, const CTransaction &txTo,
CHashWriter ss(SER_GETHASH, 0); CHashWriter ss(SER_GETHASH, 0);
ss << txTmp << sigHashType; ss << txTmp << sigHashType;
return ss.GetHash(); return ss.GetHash();
} }
bool BaseSignatureChecker::VerifySignature(const std::vector<uint8_t> &vchSig, bool BaseSignatureChecker::VerifySignature(const std::vector<uint8_t> &vchSig,
const CPubKey &pubkey, const CPubKey &pubkey,
const uint256 &sighash, const uint256 &sighash,
uint32_t flags) const { uint32_t flags) const {
deadalnixUnsubmitted
Not Done
Inline Actions

Remove - and pull the wire and remove everything that comes with it.

deadalnix: Remove - and pull the wire and remove everything that comes with it.
markblundebergAuthorUnsubmitted
Done
Inline Actions

Hmm I don't understand.

markblundeberg: Hmm I don't understand.
MengerianUnsubmitted
Not Done
Inline Actions

I think Amaury means that the flags don't need to be passed down anymore.

Ie, the "uint32_t flags" argument can be removed, as it's not used in the function anymore

Mengerian: I think Amaury means that the flags don't need to be passed down anymore. Ie, the "uint32_t…
markblundebergAuthorUnsubmitted
Done
Inline Actions

Ah ok yeah, that's in D3254 though I guess I could squash all that in if people want.

markblundeberg: Ah ok yeah, that's in D3254 though I guess I could squash all that in if people want.
MengerianUnsubmitted
Not Done
Inline Actions

Oh, I see... didn't realize that was also in D3254, in addition to the sigcache stuff.

I'm fine with doing it in a subsequent Diffs.

Mengerian: Oh, I see... didn't realize that was also in D3254, in addition to the sigcache stuff. I'm…
if ((flags & SCRIPT_ENABLE_SCHNORR) && (vchSig.size() == 64)) { if (vchSig.size() == 64) {
return pubkey.VerifySchnorr(sighash, vchSig); return pubkey.VerifySchnorr(sighash, vchSig);
} else { } else {
return pubkey.VerifyECDSA(sighash, vchSig); return pubkey.VerifyECDSA(sighash, vchSig);
} }
} }
bool TransactionSignatureChecker::CheckSig( bool TransactionSignatureChecker::CheckSig(
const std::vector<uint8_t> &vchSigIn, const std::vector<uint8_t> &vchPubKey, const std::vector<uint8_t> &vchSigIn, const std::vector<uint8_t> &vchPubKey,
▲ Show 20 Lines • Show All 200 Lines • Show Last 20 Lines