Revert "add flags to VerifySignature and sigcache"
ClosedPublic
Actions

Authored by markblundeberg on Jun 7 2019, 04:35.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T653: Clean up past upgrades

Commits

rSTAGINGbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache"
rABCbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache"

Summary

This reverts D2373, which was only done in the first place so that a
pre-activation 64-byte ECDSA signature could not fill the cache to
masquerade as a Schnorr signature post-activation. Now that the
upgrade is past and enable_schnorr flag is gone, this extra technical
complication is pointless (and it is unlikely to ever be useful again).

Depends on D3332

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Jun 7 2019, 04:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 04:35

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T653: Clean up past upgrades.Jun 7 2019, 04:38

markblundeberg edited the summary of this revision. (Show Details)Jun 7 2019, 04:40

Harbormaster completed remote builds in B6208: Diff 9235.Jun 7 2019, 04:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox added a subscriber: jasonbcox.Jun 7 2019, 17:45

jasonbcox added inline comments.

src/script/sigcache.cpp
53 ↗	(On Diff #9235)	I realize this ordering is going back to what it used to be. But that begs the question why it was changed in the first place?

markblundeberg added inline comments.Jun 7 2019, 20:15

src/script/sigcache.cpp
53 ↗	(On Diff #9235)	IIRC I changed it in order to match the order of its caller, VerifySignature. Perhaps we can keep that order, just take out `flags`. An alternative order that would also make sense is hash,pubkey,sig, which would match order of hashing.