Page MenuHomePhabricator

Clean up Segwit Recovery feature
ClosedPublic

Authored by Mengerian on Jun 4 2019, 03:53.

Details

Summary

Invert meaning of Segwit Recovery flag.
Remove segwit recovery activation
Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag

Test Plan

make check
Did IBD on main net and testnet with checkpoints=0 -assumevalid=0.
Update functional test to check for accepting blocks containing segwit recovery transactions,
rejecting segwit recovery transactions from mempool acceptance, and correct network banning.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mengerian created this revision.Jun 4 2019, 03:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2019, 03:54

This is the same as D3148, D3065, and D3160 squashed into one change.

markblundeberg added inline comments.
src/test/data/script_tests.json
3281 ↗(On Diff #9114)

It may be worth in these messages clarifying it's a "v0 P2SH-P2WPKH *segwit recovery*"

deadalnix accepted this revision.Jun 5 2019, 01:21
This revision is now accepted and ready to land.Jun 5 2019, 01:21
Mengerian updated this revision to Diff 9145.Jun 5 2019, 05:03

Update script test comments per Mark's suggestion
Rebase

Mengerian updated this revision to Diff 9146.Jun 5 2019, 05:17

Add more reviewers

markblundeberg accepted this revision.Jun 5 2019, 19:52
This revision was automatically updated to reflect the committed changes.