Page MenuHomePhabricator

Clean up past upgrades
Open, NormalPublic

Description

Goals are to simplify code, improve test coverage, and clean up tech debt.

Subcomponents of the task are:

  • Add flags to their appropriate categories, such as mandatory flags, or standard flags.
  • Add CHECKDATASIG to standard flags.
  • Add DER to mandatory flags.
  • DER seems to be eclipsed by STRICTENC, can probably be removed?
  • Add SIGPUSHONLY to mandatory flags.
  • Add CLEANSTACK to mandatory flags.
  • Delete the STANDARD+CDS group of flags as CDS should be standard.
  • Convert activation tests to feature tests.
  • Change logic of SCRIPT_ALLOW_SEGWIT_RECOVERY flag from "permissive" to "restrictive" (SCRIPT_DISALLOW_SEGWIT_RECOVERY).
  • Remove or simplify Segwit Recovery activation.
  • Add "SCRIPT_DISALLOW_SEGWIT_RECOVERY" to standard flags.
  • Remove Schnorr activation, make it "always on". Remove SCRIPT_ENABLE_SCHNORR flag.
  • Remove GreatWall activation.

Related Objects

Mentioned In
rSTAGINGbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache"
rSTAGING7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests
rSTAGINGc292cacb330f: Remove unused great wall activation code
rSTAGING0fdba130937b: remove effect of SCRIPT_ENABLE_SCHNORR flag
rSTAGINGfbcfe01efdec: Remove Schnorr activation
rSTAGINGeeed14a7916c: Clean up Segwit Recovery feature
rSTAGING282991621095: Add post-upgrade testnet checkpoint
rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
rSTAGINGf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid.
rSTAGINGb2d3f35dac10: Add CHECKDATASIG to standard flags.
rSTAGINGe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or…
rSTAGING1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
rABCbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache"
rABC7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests
rABCc292cacb330f: Remove unused great wall activation code
rABC0fdba130937b: remove effect of SCRIPT_ENABLE_SCHNORR flag
rABCfbcfe01efdec: Remove Schnorr activation
rABCeeed14a7916c: Clean up Segwit Recovery feature
rABC282991621095: Add post-upgrade testnet checkpoint
rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
rABCf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid.
rABCb2d3f35dac10: Add CHECKDATASIG to standard flags.
rABCe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or…
rABCcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
rABC1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
D3059: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS

Event Timeline

Mengerian triaged this task as Normal priority.May 16 2019, 19:53
Mengerian created this task.
Mengerian updated the task description. (Show Details)May 16 2019, 20:08
Mengerian updated the task description. (Show Details)May 17 2019, 15:06
Mengerian renamed this task from Clean up script flags to Clean up past upgrades.May 21 2019, 19:27
Mengerian updated the task description. (Show Details)May 22 2019, 05:45
markblundeberg updated the task description. (Show Details)Jun 14 2019, 16:33