Page MenuHomePhabricator
Create Task
Maniphest T653

Clean up past upgrades
Open, NormalPublic
Actions

Description

Goals are to simplify code, improve test coverage, and clean up tech debt.

Subcomponents of the task are:

  • Add flags to their appropriate categories, such as mandatory flags, or standard flags.
  • Add CHECKDATASIG to standard flags.
  • Add DER to mandatory flags.
  • DER seems to be eclipsed by STRICTENC, can probably be removed?
  • Add SIGPUSHONLY to mandatory flags.
  • Add CLEANSTACK to mandatory flags.
  • Delete the STANDARD+CDS group of flags as CDS should be standard.
  • Convert activation tests to feature tests.
  • Change logic of SCRIPT_ALLOW_SEGWIT_RECOVERY flag from "permissive" to "restrictive" (SCRIPT_DISALLOW_SEGWIT_RECOVERY).
  • Remove or simplify Segwit Recovery activation.
  • Add "SCRIPT_DISALLOW_SEGWIT_RECOVERY" to standard flags.
  • Remove Schnorr activation, make it "always on". Remove SCRIPT_ENABLE_SCHNORR flag.
  • Remove GreatWall activation.

Revisions and Commits

rABC Bitcoin ABC
Needs RevisionD5223 clean up STANDARD_NOT_MANDATORY_VERIFY_FLAGS
AbandonedD4453 [CI] Remove functional tests with graviton activation
AbandonedD3160 Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag
ClosedD3332 remove SCRIPT_ENABLE_SCHNORR flag and clean up tests
ClosedD3331 remove effect of SCRIPT_ENABLE_SCHNORR flag
ClosedD3255 Remove unused great wall activation code
ClosedD3254 Revert "add flags to VerifySignature and sigcache"
ClosedD3253 Remove Schnorr activation
ClosedD3194 Clean up Segwit Recovery feature
AbandonedD3148 Invert meaning of Segwit Recovery flag.
ClosedD3149 Add post-upgrade testnet checkpoint
AbandonedD3143 Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp
ClosedD3112 Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
ClosedD3100 Interpret scripts with CHECKDATASIG opcode always valid.
ClosedD3069 Add CHECKDATASIG to standard flags.
AbandonedD3065 Remove segwit recovery activation
ClosedD3063 Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags
ClosedD3060 Clarify comment for SCRIPT_ENABLE_CHECKDATASIG
ClosedD3059 Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS
AbandonedD2922 Add SIGPUSHONLY and CLEANSTACK to mandatory flags
AbandonedD2506 Update mandatory flags after Magnetic anomaly has activated
rSTAGING Bitcoin ABC staging
D4642rSTAGINGb6ef051607ca Cleanup graviton activation
D4746rSTAGINGd93608fbf65e clean up some tests that needlessly use -replayprotectionactivationtime
D4673rSTAGINGc6365a66ae57 add SCHNORR_MULTISIG to mandatory flags
D4679rSTAGING52e2dfeccf8e add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
D4577rSTAGING5e4ac9377001 remove NULLDUMMY

Related Objects
Search...

Event Timeline

Mengerian triaged this task as Normal priority.May 16 2019, 19:53
Mengerian created this task.
Mengerian added a revision: D2506: Update mandatory flags after Magnetic anomaly has activated.May 16 2019, 20:01
Mengerian added a revision: D2922: Add SIGPUSHONLY and CLEANSTACK to mandatory flags.
Mengerian updated the task description. (Show Details)May 16 2019, 20:08
Mengerian mentioned this in D3059: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS.May 16 2019, 20:12
Mengerian added a revision: D3059: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS.May 16 2019, 20:14
Mengerian added a revision: D3060: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG.May 16 2019, 20:36
Mengerian mentioned this in rABC1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS.May 17 2019, 00:20
Mengerian mentioned this in rABCcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG.
Mengerian updated the task description. (Show Details)May 17 2019, 15:06
Mengerian added a revision: D3063: Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags.May 17 2019, 17:01
florian added a revision: D3065: Remove segwit recovery activation.May 17 2019, 17:36
Mengerian added a revision: D3069: Add CHECKDATASIG to standard flags..May 19 2019, 04:31
Mengerian renamed this task from Clean up script flags to Clean up past upgrades.May 21 2019, 19:27
Mengerian mentioned this in rABCe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or….May 21 2019, 23:15
Mengerian updated the task description. (Show Details)May 22 2019, 05:45
Mengerian mentioned this in rABCb2d3f35dac10: Add CHECKDATASIG to standard flags..May 23 2019, 15:26
Mengerian added a revision: D3100: Interpret scripts with CHECKDATASIG opcode always valid..May 23 2019, 16:07
Mengerian mentioned this in rABCf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid..May 24 2019, 16:07
Mengerian added a revision: D3112: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..May 25 2019, 18:32
Mengerian mentioned this in rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..May 27 2019, 15:42
Mengerian added a revision: D3143: Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp.May 29 2019, 15:10
Mengerian added a revision: D3149: Add post-upgrade testnet checkpoint.
Mengerian added a revision: D3148: Invert meaning of Segwit Recovery flag..
Mengerian mentioned this in rABC282991621095: Add post-upgrade testnet checkpoint.May 30 2019, 16:39
Mengerian added a revision: D3194: Clean up Segwit Recovery feature.Jun 4 2019, 04:27
Mengerian mentioned this in rABCeeed14a7916c: Clean up Segwit Recovery feature.Jun 5 2019, 20:28
Mengerian added a revision: D3253: Remove Schnorr activation.Jun 7 2019, 03:58
markblundeberg added a revision: D3254: Revert "add flags to VerifySignature and sigcache".Jun 7 2019, 04:38
markblundeberg added a revision: D3255: Remove unused great wall activation code.Jun 7 2019, 04:52
markblundeberg added a revision: D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag.Jun 14 2019, 04:23
markblundeberg added a revision: D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Jun 14 2019, 04:26
markblundeberg updated the task description. (Show Details)Jun 14 2019, 16:33
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCfbcfe01efdec: Remove Schnorr activation.Jun 26 2019, 00:51
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC0fdba130937b: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCc292cacb330f: Remove unused great wall activation code.Jun 26 2019, 01:13
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Jun 27 2019, 18:08
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache".Jun 27 2019, 18:15
Mengerian added a revision: D3160: Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag.Aug 30 2019, 15:30
Mengerian mentioned this in rSTAGINGcaec57fc9566: Clarify comment for SCRIPT_ENABLE_CHECKDATASIG.Sep 18 2019, 23:35
Mengerian mentioned this in rSTAGING1b2531c1bd90: Remove redundant items from STANDARD_SCRIPT_VERIFY_FLAGS.
Mengerian mentioned this in rSTAGINGe048372368b8: Make tests independent of whether CHECKDATASIG is included in mandatory or….Sep 18 2019, 23:40
Mengerian mentioned this in rSTAGINGb2d3f35dac10: Add CHECKDATASIG to standard flags..
Mengerian mentioned this in rSTAGINGf5fac93cec01: Interpret scripts with CHECKDATASIG opcode always valid..Sep 18 2019, 23:44
Mengerian mentioned this in rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..Sep 18 2019, 23:49
Mengerian mentioned this in rSTAGING282991621095: Add post-upgrade testnet checkpoint.Sep 18 2019, 23:54
Mengerian mentioned this in rSTAGINGeeed14a7916c: Clean up Segwit Recovery feature.Sep 19 2019, 00:04
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGfbcfe01efdec: Remove Schnorr activation.Sep 19 2019, 00:33
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGc292cacb330f: Remove unused great wall activation code.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING0fdba130937b: remove effect of SCRIPT_ENABLE_SCHNORR flag.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING7cfc38d37a8f: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.Sep 19 2019, 00:38
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGbdb4d1daa99d: Revert "add flags to VerifySignature and sigcache".
Mengerian added a revision: D4453: [CI] Remove functional tests with graviton activation.Nov 25 2019, 20:57
Mengerian added a subtask: T703: clean up schnorr activations.Nov 28 2019, 22:21
Mengerian added a revision: D4577: remove NULLDUMMY.Nov 29 2019, 18:12
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABC5e4ac9377001: remove NULLDUMMY.Dec 2 2019, 19:12
Mengerian added a revision: D4642: Cleanup graviton activation.Dec 5 2019, 19:03
Fabien mentioned this in D4642: Cleanup graviton activation.Dec 6 2019, 06:54
Mengerian added a revision: D4673: add SCHNORR_MULTISIG to mandatory flags.Dec 10 2019, 03:46
Mengerian added a revision: D4679: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.Dec 10 2019, 10:09
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.Dec 12 2019, 21:33
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABCc6365a66ae57: add SCHNORR_MULTISIG to mandatory flags.Dec 17 2019, 03:57
markblundeberg added a revision: D4746: clean up some tests that needlessly use -replayprotectionactivationtime.Dec 17 2019, 23:57
Fabien mentioned this in rABCb6ef051607ca: Cleanup graviton activation.Dec 20 2019, 19:21
markblundeberg added a revision: D5223: clean up STANDARD_NOT_MANDATORY_VERIFY_FLAGS.Feb 8 2020, 07:15
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING5e4ac9377001: remove NULLDUMMY.Apr 7 2020, 21:58
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.Apr 7 2020, 22:03
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGc6365a66ae57: add SCHNORR_MULTISIG to mandatory flags.Apr 7 2020, 22:05
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGd93608fbf65e: clean up some tests that needlessly use -replayprotectionactivationtime.
Fabien added a commit: rSTAGINGb6ef051607ca: Cleanup graviton activation.Apr 7 2020, 22:12