Page MenuHomePhabricator

Clean up past upgrades
Open, NormalPublic


Goals are to simplify code, improve test coverage, and clean up tech debt.

Subcomponents of the task are:

  • Add flags to their appropriate categories, such as mandatory flags, or standard flags.
  • Add CHECKDATASIG to standard flags.
  • Add DER to mandatory flags.
  • DER seems to be eclipsed by STRICTENC, can probably be removed?
  • Add SIGPUSHONLY to mandatory flags.
  • Add CLEANSTACK to mandatory flags.
  • Delete the STANDARD+CDS group of flags as CDS should be standard.
  • Convert activation tests to feature tests.
  • Change logic of SCRIPT_ALLOW_SEGWIT_RECOVERY flag from "permissive" to "restrictive" (SCRIPT_DISALLOW_SEGWIT_RECOVERY).
  • Remove or simplify Segwit Recovery activation.
  • Add "SCRIPT_DISALLOW_SEGWIT_RECOVERY" to standard flags.
  • Remove Schnorr activation, make it "always on". Remove SCRIPT_ENABLE_SCHNORR flag.
  • Remove GreatWall activation.

Related Objects

Event Timeline

Mengerian triaged this task as Normal priority.May 16 2019, 19:53
Mengerian created this task.
Mengerian updated the task description. (Show Details)May 16 2019, 20:08
Mengerian updated the task description. (Show Details)May 17 2019, 15:06
Mengerian renamed this task from Clean up script flags to Clean up past upgrades.May 21 2019, 19:27
Mengerian updated the task description. (Show Details)May 22 2019, 05:45
markblundeberg updated the task description. (Show Details)Jun 14 2019, 16:33