HomePhabricator

Make tests independent of whether CHECKDATASIG is included in mandatory or…

Authored by Mengerian on May 17 2019, 15:47.

Description

Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags

Summary:
Currently, in addition to testing the functioning of CHECKDATASIG,
sigopcount_tests.cpp and checkdatasig_tests.cpp implicitly test that
CHECKDATASIG is not included in standard or mandatory flags.

Change this to make the CHECKDATASIG tests independent of whether CHECKDATASIG
is included in standard or mandatory flags. To maintain test coverage, also
add a test to explicitly test whether CHECKDATASIG is included in standard or
mandatory flags.

Test Plan:
make check - passes
Try adding CHECKDATASIG to standard flags - make check - test fails.
Try adding CHECKDATASIG to mandatory flags - make check - test fails.

Reviewers: deadalnix, Fabien, #bitcoin_abc, markblundeberg

Reviewed By: deadalnix, #bitcoin_abc

Maniphest Tasks: T653

Differential Revision: https://reviews.bitcoinabc.org/D3063

Details

Committed
MengerianMay 21 2019, 23:15
Pushed
MengerianMay 21 2019, 23:15
Reviewer
Restricted Project
Differential Revision
D3063: Make tests independent of whether CHECKDATASIG is included in mandatory or standard flags
Parents
rABCf8fefbeb567e: Merge #13522: [tests] Fix p2p_sendheaders race
Branches
Unknown
Tags
Unknown