HomePhabricator

Merge #13522: [tests] Fix p2p_sendheaders race

Description

Merge #13522: [tests] Fix p2p_sendheaders race

Summary:
PR13522 backport https://github.com/bitcoin/bitcoin/pull/13522/files
75848bcf40 [tests] Fix p2p_sendheaders race (John Newbery)

Pull request description:

p2p_sendheaders has a race in part 1.3.

part 1.2 sends a block to the node over the 'test_node' connection, but
doesn't wait for an inv to be received on the 'inv_node' connection. If
we get to part 1.3 before that inv has been received, then the
subsequent call to check_last_inv_announcement could fail.

Depends on D3088

Test Plan: test_runner.py

Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T454

Differential Revision: https://reviews.bitcoinabc.org/D3089

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on May 21 2019, 21:41
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Committed on May 21 2019, 21:41
markblundebergPushed on May 21 2019, 21:41
Reviewer
Restricted Project
Differential Revision
D3089: Merge #13522: [tests] Fix p2p_sendheaders race
Parents
rABCe6b67d116af3: Merge #13350: [tests] Add logging to provide anchor points when debugging…
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf8fefbeb567e: Merge #13522: [tests] Fix p2p_sendheaders race (authored by MarcoFalke <falke.marco@gmail.com>).May 21 2019, 21:41