Page MenuHomePhabricator


Authored by Mengerian on May 25 2019, 03:28.



The new name is more descriptive of what the flag actually does.

This is a straight rename with no other changes.

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mengerian created this revision.May 25 2019, 03:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2019, 03:28
Mengerian added a comment.EditedMay 25 2019, 03:31

In the review of D3100, @markblundeberg had suggested renaming the flag. This Diff does that.

markblundeberg added inline comments.May 25 2019, 07:38
153 ↗(On Diff #8869)

Now that the flag is renamed, this kind of thing looks silly (as it should!). :-)
Part of why I wanted to see this renaming is that it reveals all these usages.

Removing these silly parts can be done in separate Diff though.

255 ↗(On Diff #8869)

Does belong here of course...

244 ↗(On Diff #8869)

ditto for plainly visible silliness, as with all other instances in script_tests

39 ↗(On Diff #8869)

Oopsie! Keep this commented. :-)

718 ↗(On Diff #8869)

Hmm this ought to have been removed in previous diff, ah well.

1663 ↗(On Diff #8869)

(this of course stays)

LGTM, except just recomment that line in script_tests.cpp .

Mengerian marked an inline comment as done.May 25 2019, 14:47
Mengerian added inline comments.
39 ↗(On Diff #8869)

Oops, will re-comment that

Mengerian updated this revision to Diff 8876.May 25 2019, 14:48
Mengerian marked an inline comment as done.

Re-comment auto-test generating #define
Rebase on master

deadalnix requested changes to this revision.May 26 2019, 20:00
deadalnix added inline comments.
244 ↗(On Diff #8876)

No need to rename flags in there.

34 ↗(On Diff #8876)

No need to rename this flag

This revision now requires changes to proceed.May 26 2019, 20:00
Mengerian updated this revision to Diff 8903.May 27 2019, 03:15
Mengerian edited the summary of this revision. (Show Details)

Don't rename flag in script tests.
Rebase on master.

deadalnix accepted this revision.May 27 2019, 14:30
This revision is now accepted and ready to land.May 27 2019, 14:30