Page MenuHomePhabricator
Differential D3112

Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
ClosedPublic
Actions

Authored by Mengerian on May 25 2019, 03:28.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Commits
rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS.
Summary

The new name is more descriptive of what the flag actually does.

This is a straight rename with no other changes.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cds-rename-flag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6011
Build 10081: Bitcoin ABC Buildbot (legacy)
Build 10080: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 25 2019, 03:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 25 2019, 03:28
teamcity added a comment.May 25 2019, 03:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian added a comment.EditedMay 25 2019, 03:31

In the review of D3100, @markblundeberg had suggested renaming the flag. This Diff does that.

teamcity added a comment.May 25 2019, 03:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5982: Diff 8869.May 25 2019, 03:43
markblundeberg added inline comments.May 25 2019, 07:38
src/test/checkdatasig_tests.cpp
153 ↗(On Diff #8869)

Now that the flag is renamed, this kind of thing looks silly (as it should!). :-)
Part of why I wanted to see this renaming is that it reveals all these usages.

Removing these silly parts can be done in separate Diff though.

255 ↗(On Diff #8869)

Does belong here of course...

src/test/data/script_tests.json
244 ↗(On Diff #8869)

ditto for plainly visible silliness, as with all other instances in script_tests

src/test/script_tests.cpp
39 ↗(On Diff #8869)

Oopsie! Keep this commented. :-)

src/validation.cpp
718 ↗(On Diff #8869)

Hmm this ought to have been removed in previous diff, ah well.

1663 ↗(On Diff #8869)

(this of course stays)

markblundeberg added a comment.May 25 2019, 07:39

LGTM, except just recomment that line in script_tests.cpp .

Mengerian marked an inline comment as done.May 25 2019, 14:47
Mengerian added inline comments.
src/test/script_tests.cpp
39 ↗(On Diff #8869)

Oops, will re-comment that

Mengerian updated this revision to Diff 8876.May 25 2019, 14:48
Mengerian marked an inline comment as done.

Re-comment auto-test generating #define
Rebase on master

teamcity added a comment.May 25 2019, 14:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5984: Diff 8876.May 25 2019, 15:03
teamcity added a comment.May 25 2019, 15:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mengerian added a task: T653: Clean up past upgrades.May 25 2019, 18:32
deadalnix requested changes to this revision.May 26 2019, 20:00
deadalnix added inline comments.
src/test/data/script_tests.json
244 ↗(On Diff #8876)

No need to rename flags in there.

src/test/scriptflags.cpp
34 ↗(On Diff #8876)

No need to rename this flag

This revision now requires changes to proceed.May 26 2019, 20:00
Mengerian updated this revision to Diff 8903.May 27 2019, 03:15
Mengerian edited the summary of this revision. (Show Details)

Don't rename flag in script tests.
Rebase on master.

teamcity added a comment.May 27 2019, 03:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 03:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6002: Diff 8903.May 27 2019, 03:30
deadalnix accepted this revision.May 27 2019, 14:30
This revision is now accepted and ready to land.May 27 2019, 14:30
Mengerian updated this revision to Diff 8920.May 27 2019, 15:21

Rebase

Mengerian updated this revision to Diff 8921.May 27 2019, 15:23

Rebase

teamcity added a comment.May 27 2019, 15:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 27 2019, 15:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6011: Diff 8921.May 27 2019, 15:37
teamcity added a comment.May 27 2019, 15:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.May 27 2019, 15:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6010: Diff 8920.May 27 2019, 15:38
Closed by commit rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS. (authored by Mengerian). · Explain WhyMay 27 2019, 15:42
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..
Mengerian added a commit: rSTAGINGed9bf5b2e489: Rename SCRIPT_ENABLE_CHECKDATASIG to SCRIPT_VERIFY_CHECKDATASIG_SIGOPS..Sep 18 2019, 23:48

Revision Contents
Changeset List

PathSize
src/
consensus/
2 lines
policy/
2 lines
script/
2 lines
2 lines
2 lines
test/
28 lines
2 lines
60 lines
2 lines
2 lines
8 lines
4 lines

Diff 8921

View Options

src/consensus/tx_verify.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/script/script_flags.h

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/test/checkdatasig_tests.cpp

Loading...
View Options

src/test/schnorr_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/scriptflags.cpp

Loading...
View Options

src/test/sigcache_tests.cpp

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...