HomePhabricator

add SCHNORR_MULTISIG to mandatory flags

Description

add SCHNORR_MULTISIG to mandatory flags

Summary:
Note that this makes pre-activation mempool behaviour slightly weird, as
noted in the test. In practice now that the upgrade has passed and is
checkpointed, only a new node during IBD can be in a preactivated state,
and a new node will anyway not request transactions before finishing IBD.

It may be worth adding tests of fresh-node IBD behaviour in a future
commit; similar behaviour occurs for any additive flag that is included
in mandatory flags.

Test Plan:

make check
test_runner.py

Reviewers: Mengerian, #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T653

Differential Revision: https://reviews.bitcoinabc.org/D4673

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Dec 9 2019, 22:39
Mark Lundeberg <markblundeberg@users.noreply.github.com>Committed on Dec 17 2019, 03:57
markblundebergPushed on Dec 17 2019, 03:57
Reviewer
Restricted Project
Differential Revision
D4673: add SCHNORR_MULTISIG to mandatory flags
Parents
rABC1b3100b9ed90: Make more script validation flags backward compatible
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <markblundeberg@users.noreply.github.com> committed rABCc6365a66ae57: add SCHNORR_MULTISIG to mandatory flags (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Dec 17 2019, 03:57