Page MenuHomePhabricator

Rename SCRIPT_VERIFY_CHECKDATASIG_SIGOPS flag in scriptflags.cpp
AbandonedPublic

Authored by Mengerian on May 28 2019, 17:13.

Details

Reviewers
deadalnix
markblundeberg
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Summary

This makes the tests more readable (If the flag ever ends up getting used again).
It's mildly confusing (and worse for searching) that the name of the flag
is exactly the same as the name of the opcode.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cds-rename-flag-in-scriptflags
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6041
Build 10141: Bitcoin ABC Buildbot (legacy)
Build 10140: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 28 2019, 17:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 28 2019, 17:13
deadalnix requested changes to this revision.May 29 2019, 15:03

That is not necessary.

This revision now requires changes to proceed.May 29 2019, 15:03