Page MenuHomePhabricator

Remove unused great wall activation code
AcceptedPublic

Authored by markblundeberg on Fri, Jun 7, 04:52.

Details

Reviewers
jasonbcox
Fabien
Mengerian
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Summary

Like monolith upgrade, this one was possible to make retroactively
always active. After this change, "great wall" is only mentioned in
the chainparams.cpp checkpoint comment.

Depends on D3253 and D3194

Test Plan

make check
test_runner.py (to show nothing was using -greatwallactivationtime)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remgreatwall
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6337
Build 10721: Bitcoin ABC Teamcity Staging
Build 10720: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Fri, Jun 7, 04:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 04:52
markblundeberg retitled this revision from Remove all great wall activation code to Remove unused great wall activation code.
markblundeberg edited the summary of this revision. (Show Details)
Mengerian accepted this revision as: Mengerian.Fri, Jun 7, 06:00

Looks good to me.

This revision is now accepted and ready to land.Fri, Jun 7, 06:00

rebase onto split parent