Page MenuHomePhabricator

Remove unused great wall activation code
ClosedPublic

Authored by markblundeberg on Jun 7 2019, 04:52.

Details

Summary

Like monolith upgrade, this one was possible to make retroactively
always active. After this change, "great wall" is only mentioned in
the chainparams.cpp checkpoint comment.

Depends on D3253 and D3194

Test Plan

make check
test_runner.py (to show nothing was using -greatwallactivationtime)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jun 7 2019, 04:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 04:52
markblundeberg retitled this revision from Remove all great wall activation code to Remove unused great wall activation code.
markblundeberg edited the summary of this revision. (Show Details)
Mengerian accepted this revision as: Mengerian.Jun 7 2019, 06:00

Looks good to me.

This revision is now accepted and ready to land.Jun 7 2019, 06:00

rebase onto split parent

rebase simply due to age