Page MenuHomePhabricator
Differential D3255

Remove unused great wall activation code
ClosedPublic
Actions

Authored by markblundeberg on Jun 7 2019, 04:52.

Details

Reviewers
jasonbcox
Fabien
Mengerian
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Commits
rSTAGINGc292cacb330f: Remove unused great wall activation code
rABCc292cacb330f: Remove unused great wall activation code
Summary

Like monolith upgrade, this one was possible to make retroactively
always active. After this change, "great wall" is only mentioned in
the chainparams.cpp checkpoint comment.

Depends on D3253 and D3194

Test Plan

make check
test_runner.py (to show nothing was using -greatwallactivationtime)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remgreatwall
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6337
Build 10721: Bitcoin ABC Buildbot (legacy)
Build 10720: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jun 7 2019, 04:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 04:52
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 7 2019, 04:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a task: T653: Clean up past upgrades.Jun 7 2019, 04:52
markblundeberg retitled this revision from Remove all great wall activation code to Remove unused great wall activation code.
markblundeberg edited the summary of this revision. (Show Details)
markblundeberg added a parent revision: D3194: Clean up Segwit Recovery feature.
Harbormaster completed remote builds in B6209: Diff 9236.Jun 7 2019, 05:02
teamcity added a comment.Jun 7 2019, 05:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mengerian accepted this revision as: Mengerian.Jun 7 2019, 06:00

Looks good to me.

This revision is now accepted and ready to land.Jun 7 2019, 06:00
markblundeberg updated this revision to Diff 9429.Jun 14 2019, 04:49

rebase onto split parent

teamcity added a comment.Jun 14 2019, 04:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 14 2019, 04:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6337: Diff 9429.Jun 14 2019, 04:59
markblundeberg updated this revision to Diff 9670.Jun 26 2019, 00:58

rebase simply due to age

teamcity added a comment.Jun 26 2019, 00:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 26 2019, 01:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6484: Diff 9670.Jun 26 2019, 01:09
Closed by commit rABCc292cacb330f: Remove unused great wall activation code (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyJun 26 2019, 01:13
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCc292cacb330f: Remove unused great wall activation code.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGc292cacb330f: Remove unused great wall activation code.Sep 19 2019, 00:33

Revision Contents
Changeset List

PathSize
src/
9 lines
consensus/
3 lines
11 lines
2 lines
test/
24 lines
5 lines
test/
lint/
2 lines

Diff 9429

View Options

src/chainparams.cpp

Loading...
View Options

src/consensus/activation.h

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/lint/check-doc.py

Loading...