Page MenuHomePhabricator

sigencoding_tests: improve test coverage
ClosedPublic

Authored by markblundeberg on Jun 8 2019, 21:43.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rABC9f5daed870aa: sigencoding_tests: improve test coverage
Summary

We weren't checking a huge number of hashtype byte variations for 64-byte
signatures, though some hashtype checks are done in script_tests.

This prepares for adding a Schnorr-only sigencoding checker.

Depends on D3331

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jun 8 2019, 21:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 8 2019, 21:43
markblundeberg planned changes to this revision.Jun 14 2019, 04:18
markblundeberg edited the summary of this revision. (Show Details)

rebased onto split-up schnorr removal diffs

deadalnix accepted this revision.Jun 25 2019, 20:26
This revision is now accepted and ready to land.Jun 25 2019, 20:26