HomePhabricator

sigencoding_tests: improve test coverage

Description

sigencoding_tests: improve test coverage

Summary:
We weren't checking a huge number of hashtype byte variations for 64-byte
signatures, though some hashtype checks are done in script_tests.

This prepares for adding a Schnorr-only sigencoding checker.

Depends on D3331

Test Plan: make check

Reviewers: deadalnix, Mengerian, #bitcoin_abc

Reviewed By: deadalnix, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D3264

Details

Provenance
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Authored on Jun 5 2019, 23:35
markblundebergPushed on Jun 26 2019, 01:13
Reviewer
Restricted Project
Differential Revision
D3264: sigencoding_tests: improve test coverage
Parents
rABCc292cacb330f: Remove unused great wall activation code
Branches
Unknown
Tags
Unknown

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC9f5daed870aa: sigencoding_tests: improve test coverage (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jun 26 2019, 01:13