HomePhabricator

remove effect of SCRIPT_ENABLE_SCHNORR flag

Description

remove effect of SCRIPT_ENABLE_SCHNORR flag

Summary:
Originally, the SCRIPT_ENABLE_SCHNORR flag was added first without any
effect, then later diffs put in the functionality. This Diff removes the
effect of the SCRIPT_ENABLE_SCHNORR flag, but keeps the flag around.
Some tests have to be removed accordingly since they were specifically
testing flag-off behaviour that is no longer true.

(effectively this is a backing-out of D2455 and D2469)

Depends on D3253

Test Plan:
make check
test_runner.py --extended

  • IBD with -checkpoints=0 and -assumevalid=0 on testnet
  • IBD with -checkpoints=0 and -assumevalid=0 on mainnet

Reviewers: deadalnix, Mengerian, #bitcoin_abc

Reviewed By: deadalnix, Mengerian, #bitcoin_abc

Subscribers: jasonbcox

Maniphest Tasks: T653

Differential Revision: https://reviews.bitcoinabc.org/D3331

Details

Committed
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>Jun 26 2019, 00:52
Pushed
markblundebergJun 26 2019, 00:58
Reviewer
Restricted Project
Differential Revision
D3331: remove effect of SCRIPT_ENABLE_SCHNORR flag
Parents
rSTAGINGfbcfe01efdec: Remove Schnorr activation
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/9670

Event Timeline

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rSTAGING0fdba130937b: remove effect of SCRIPT_ENABLE_SCHNORR flag (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).Jun 26 2019, 00:52