Page MenuHomePhabricator

add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
ClosedPublic

Authored by markblundeberg on Dec 10 2019, 08:24.

Details

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Dec 10 2019, 08:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 08:24
deadalnix accepted this revision.Dec 11 2019, 01:28

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

This revision is now accepted and ready to land.Dec 11 2019, 01:28

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

The multisig one is in progress: D4673.

As for checkdatasig, that one seems to be arbitrarily forbidden by a test right now (see end of checkdatasig_tests, comes from D3063, D3069). And it shouldn't matter since mandatory flags are only used when standard flags have been failed and we're deciding whether to ban a peer.