Page MenuHomePhabricator
Differential D4679

add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
ClosedPublic
Actions

Authored by markblundeberg on Dec 10 2019, 08:24.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Commits
rSTAGING52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
rABC52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Dec 10 2019, 08:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 08:24
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 10 2019, 08:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 10 2019, 08:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8471: Diff 14720.Dec 10 2019, 08:39
Mengerian added a task: T653: Clean up past upgrades.Dec 10 2019, 10:09
deadalnix accepted this revision.Dec 11 2019, 01:28

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

This revision is now accepted and ready to land.Dec 11 2019, 01:28
markblundeberg added a comment.Dec 12 2019, 09:25
In D4679#112923, @deadalnix wrote:

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

The multisig one is in progress: D4673.

As for checkdatasig, that one seems to be arbitrarily forbidden by a test right now (see end of checkdatasig_tests, comes from D3063, D3069). And it shouldn't matter since mandatory flags are only used when standard flags have been failed and we're deciding whether to ban a peer.

Closed by commit rABC52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 12 2019, 21:33
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.
markblundeberg mentioned this in D4673: add SCHNORR_MULTISIG to mandatory flags.Dec 12 2019, 21:47
markblundeberg mentioned this in D4642: Cleanup graviton activation.Dec 12 2019, 23:17
markblundeberg mentioned this in D5221: Make STANDARD_SCRIPT_VERIFY_FLAGS explicit.Feb 8 2020, 06:49
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags.Apr 7 2020, 22:03

Revision Contents
Changeset List

PathSize
src/
script/
3 lines
1 line
test/
functional/
17 lines

Diff 14810

View Options

src/script/standard.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-minimaldata-activation.py

Loading...