add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
ClosedPublic
Actions

Authored by markblundeberg on Dec 10 2019, 08:24.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

T653: Clean up past upgrades

Commits

rSTAGING52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags
rABC52e2dfeccf8e: add SCRIPT_VERIFY_MINIMALDATA to mandatory flags

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mand-minimal

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8471
Build 14953: Default Diff Build & Tests
Build 14952: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 10 2019, 08:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 08:24

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8471: Diff 14720.Dec 10 2019, 08:39

Mengerian added a task: T653: Clean up past upgrades.Dec 10 2019, 10:09

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

This revision is now accepted and ready to land.Dec 11 2019, 01:28

In D4679#112923, @deadalnix wrote:

Could you do the same for SCRIPT_ENABLE_SCHNORR_MULTISIG and SCRIPT_VERIFY_CHECKDATASIG_SIGOPS, please?

The multisig one is in progress: D4673.

As for checkdatasig, that one seems to be arbitrarily forbidden by a test right now (see end of checkdatasig_tests, comes from D3063, D3069). And it shouldn't matter since mandatory flags are only used when standard flags have been failed and we're deciding whether to ban a peer.