Page MenuHomePhabricator

remove NULLDUMMY
ClosedPublic

Authored by markblundeberg on Fri, Nov 29, 04:12.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T653: Clean up past upgrades
Commits
rABC5e4ac9377001: remove NULLDUMMY
Summary

Now that the Schnorr multisig upgrade is active, the NULLDUMMY standard
flag is totally superseded and pointless.

Test Plan
make check
test_runner.py

run IBD

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Fri, Nov 29, 04:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 04:12
markblundeberg added inline comments.Fri, Nov 29, 04:16
src/script/bitcoinconsensus.h
55 ↗(On Diff #14496)

better to put _DEPRECATED like the WITNESS flag?

src/test/data/script_tests.json
3348 ↗(On Diff #14496)

will rm

test/functional/abc-schnorrmultisig-activation.py
58 ↗(On Diff #14496)

technically unrelated comment change but I missed it in previous Diff; happy to leave out if that is wanted.

remove spurious newline and request teamcity rerun

Great to see this!

Just to be safe, I think doing an IBD should be added to the test plan.

deadalnix requested changes to this revision.Fri, Nov 29, 14:11
deadalnix edited the test plan for this revision. (Show Details)

Please Run IBD, otherwise, LGTM.

I edited the test plan, you don't need to use backticks on every line :)

This revision now requires changes to proceed.Fri, Nov 29, 14:12
markblundeberg edited the test plan for this revision. (Show Details)Fri, Nov 29, 15:57
deadalnix accepted this revision.Sat, Nov 30, 17:51
This revision is now accepted and ready to land.Sat, Nov 30, 17:51