Page MenuHomePhabricator


Authored by markblundeberg on Nov 29 2019, 04:12.



Now that the Schnorr multisig upgrade is active, the NULLDUMMY standard
flag is totally superseded and pointless.

Test Plan
make check

run IBD

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Nov 29 2019, 04:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2019, 04:12
markblundeberg added inline comments.Nov 29 2019, 04:16
55 ↗(On Diff #14496)

better to put _DEPRECATED like the WITNESS flag?

3348 ↗(On Diff #14496)

will rm

58 ↗(On Diff #14496)

technically unrelated comment change but I missed it in previous Diff; happy to leave out if that is wanted.

remove spurious newline and request teamcity rerun

Great to see this!

Just to be safe, I think doing an IBD should be added to the test plan.

deadalnix requested changes to this revision.Nov 29 2019, 14:11
deadalnix edited the test plan for this revision. (Show Details)

Please Run IBD, otherwise, LGTM.

I edited the test plan, you don't need to use backticks on every line :)

This revision now requires changes to proceed.Nov 29 2019, 14:12
markblundeberg edited the test plan for this revision. (Show Details)Nov 29 2019, 15:57
deadalnix accepted this revision.Nov 30 2019, 17:51
This revision is now accepted and ready to land.Nov 30 2019, 17:51