Differential D4577

remove NULLDUMMY
ClosedPublic
Actions

Authored by markblundeberg on Nov 29 2019, 04:12.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

T653: Clean up past upgrades

Commits

rSTAGING5e4ac9377001: remove NULLDUMMY
rABC5e4ac9377001: remove NULLDUMMY

Summary

Now that the Schnorr multisig upgrade is active, the NULLDUMMY standard
flag is totally superseded and pointless.

Test Plan

make check
test_runner.py

run IBD

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markblundeberg created this revision.Nov 29 2019, 04:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2019, 04:12

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added inline comments.Nov 29 2019, 04:16

src/script/bitcoinconsensus.h
55 ↗	(On Diff #14496)	better to put _DEPRECATED like the WITNESS flag?
src/test/data/script_tests.json
3348 ↗	(On Diff #14496)	will rm
test/functional/abc-schnorrmultisig-activation.py
58 ↗	(On Diff #14496)	technically unrelated comment change but I missed it in previous Diff; happy to leave out if that is wanted.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8328: Diff 14496!Nov 29 2019, 04:23

remove spurious newline and request teamcity rerun

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8329: Diff 14497.Nov 29 2019, 04:57

Great to see this!

Just to be safe, I think doing an IBD should be added to the test plan.

Please Run IBD, otherwise, LGTM.

I edited the test plan, you don't need to use backticks on every line :)

This revision now requires changes to proceed.Nov 29 2019, 14:12

markblundeberg edited the test plan for this revision. (Show Details)Nov 29 2019, 15:57

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Mengerian added a task: T653: Clean up past upgrades.Nov 29 2019, 18:12

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

deadalnix accepted this revision.Nov 30 2019, 17:51

This revision is now accepted and ready to land.Nov 30 2019, 17:51

Closed by commit rABC5e4ac9377001: remove NULLDUMMY (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyDec 2 2019, 19:12

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC5e4ac9377001: remove NULLDUMMY.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING5e4ac9377001: remove NULLDUMMY.Apr 7 2020, 21:58

Revision Contents
Changeset List

Path

Size

doc/

shared-libraries.md

1 line

src/

policy/

9 lines

script/

bitcoinconsensus.h

3 lines

interpreter.cpp

12 lines

1 line

script_error.cpp

2 lines

4 lines

test/

data/

script_tests.json

26 lines

tx_invalid.json

20 lines

3 lines

script_tests.cpp

44 lines

scriptflags.cpp

1 line

test/

functional/

abc-schnorrmultisig-activation.py

26 lines

feature_nulldummy.py

6 lines

Diff 14578

doc/shared-libraries.md

Loading...

src/policy/policy.h

Loading...

src/script/bitcoinconsensus.h

Loading...

src/script/interpreter.cpp

Loading...

src/script/script_error.h

Loading...

src/script/script_error.cpp

Loading...

src/script/script_flags.h

Loading...

src/test/data/script_tests.json

Loading...

src/test/data/tx_invalid.json

Loading...

src/test/data/tx_valid.json

Loading...

src/test/script_tests.cpp

Loading...

src/test/scriptflags.cpp

Loading...

test/functional/abc-schnorrmultisig-activation.py

Loading...

test/functional/feature_nulldummy.py

Loading...

test/functional/timing.json

Loading...