Page MenuHomePhabricator

Update timing.json Segwit Recovery functional test name
ClosedPublic

Authored by Mengerian on Fri, Jun 7, 19:03.

Details

Summary

This update was overlooked when the functional test name was changed in D3194

Test Plan

Run test/functional/test_runner.py and compare the generated timing.json file

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mengerian created this revision.Fri, Jun 7, 19:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jun 7, 19:03
Fabien accepted this revision.Sat, Jun 8, 13:49
Fabien added inline comments.
test/functional/timing.json
414 ↗(On Diff #9248)

If the newline was not generated, don't add it otherwise it will conflict at every update.

This revision is now accepted and ready to land.Sat, Jun 8, 13:49
Mengerian added inline comments.Sat, Jun 8, 15:10
test/functional/timing.json
414 ↗(On Diff #9248)

My editor did that for some reason.

I will remove it.

markblundeberg added inline comments.
test/functional/timing.json
414 ↗(On Diff #9248)

Yeah mine did too, in my diff. I imagine the issue is that the autogenerator doesn't leave a trailing space.

Mengerian updated this revision to Diff 9256.Sat, Jun 8, 15:27

Remove added newline

Fabien added inline comments.Sat, Jun 8, 15:34
test/functional/timing.json
414 ↗(On Diff #9248)

Sure having a generated newline will be even better

This revision was automatically updated to reflect the committed changes.