Page MenuHomePhabricator
Differential D3258

Update timing.json Segwit Recovery functional test name
ClosedPublic
Actions

Authored by Mengerian on Jun 7 2019, 19:03.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name
rABC3c56495801af: Update timing.json Segwit Recovery functional test name
Summary

This update was overlooked when the functional test name was changed in D3194

Test Plan

Run test/functional/test_runner.py and compare the generated timing.json file

Diff Detail

Repository
rABC Bitcoin ABC
Branch
timing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6215
Build 10477: Bitcoin ABC Buildbot (legacy)
Build 10476: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jun 7 2019, 19:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2019, 19:03
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jun 7 2019, 19:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 7 2019, 19:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6215: Diff 9248.Jun 7 2019, 19:15
Fabien accepted this revision.Jun 8 2019, 13:49
Fabien added inline comments.
test/functional/timing.json
414

If the newline was not generated, don't add it otherwise it will conflict at every update.

This revision is now accepted and ready to land.Jun 8 2019, 13:49
Mengerian added inline comments.Jun 8 2019, 15:10
test/functional/timing.json
414

My editor did that for some reason.

I will remove it.

markblundeberg added a subscriber: markblundeberg.Jun 8 2019, 15:17
markblundeberg added inline comments.
test/functional/timing.json
414

Yeah mine did too, in my diff. I imagine the issue is that the autogenerator doesn't leave a trailing space.

Mengerian updated this revision to Diff 9256.Jun 8 2019, 15:27

Remove added newline

teamcity added a comment.Jun 8 2019, 15:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6221: Diff 9256.Jun 8 2019, 15:33
teamcity added a comment.Jun 8 2019, 15:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added inline comments.Jun 8 2019, 15:34
test/functional/timing.json
414

Sure having a generated newline will be even better

Closed by commit rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian). · Explain WhyJun 8 2019, 17:36
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABC3c56495801af: Update timing.json Segwit Recovery functional test name.
Mengerian added a commit: rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name.Sep 19 2019, 00:09

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 9248

View Options

test/functional/timing.json

Loading...