This update was overlooked when the functional test name was changed in D3194
Details
Details
- Reviewers
Fabien deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING3c56495801af: Update timing.json Segwit Recovery functional test name
rABC3c56495801af: Update timing.json Segwit Recovery functional test name
Run test/functional/test_runner.py and compare the generated timing.json file
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- timing
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6221 Build 10489: Bitcoin ABC Buildbot (legacy) Build 10488: arc lint + arc unit
Event Timeline
| test/functional/timing.json | ||
|---|---|---|
| 414 ↗ | (On Diff #9248) | If the newline was not generated, don't add it otherwise it will conflict at every update. |
| test/functional/timing.json | ||
|---|---|---|
| 414 ↗ | (On Diff #9248) | My editor did that for some reason. I will remove it. |
| test/functional/timing.json | ||
|---|---|---|
| 414 ↗ | (On Diff #9248) | Yeah mine did too, in my diff. I imagine the issue is that the autogenerator doesn't leave a trailing space. |
| test/functional/timing.json | ||
|---|---|---|
| 414 ↗ | (On Diff #9248) | Sure having a generated newline will be even better |