Page MenuHomePhabricator

Update timing.json Segwit Recovery functional test name
ClosedPublic

Authored by Mengerian on Jun 7 2019, 19:03.

Details

Summary

This update was overlooked when the functional test name was changed in D3194

Test Plan

Run test/functional/test_runner.py and compare the generated timing.json file

Diff Detail

Repository
rABC Bitcoin ABC
Branch
timing
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6221
Build 10489: Bitcoin ABC Buildbot (legacy)
Build 10488: arc lint + arc unit

Event Timeline

Fabien added inline comments.
test/functional/timing.json
414 ↗(On Diff #9248)

If the newline was not generated, don't add it otherwise it will conflict at every update.

This revision is now accepted and ready to land.Jun 8 2019, 13:49
test/functional/timing.json
414 ↗(On Diff #9248)

My editor did that for some reason.

I will remove it.

markblundeberg added inline comments.
test/functional/timing.json
414 ↗(On Diff #9248)

Yeah mine did too, in my diff. I imagine the issue is that the autogenerator doesn't leave a trailing space.

test/functional/timing.json
414 ↗(On Diff #9248)

Sure having a generated newline will be even better