Differential D4267 Diff 13608 cmake/modules/PackageOptions.cmake

Changeset View

Standalone View

cmake/modules/PackageOptions.cmake

This file was added.

				# Package options
				set(CPACK_PACKAGE_VENDOR "The Bitcoin developers")
				set(CPACK_PACKAGE_DESCRIPTION "Bitcoin ABC is a Bitcoin Cash full node implementation.")
				jasonbcoxUnsubmitted Not Done Inline Actions Seeing as the PROJECT_HOMEPAGE_URL lives somewhere else, shouldn't the vendor and description live in a similar common place also? jasonbcox: Seeing as the PROJECT_HOMEPAGE_URL lives somewhere else, shouldn't the vendor and description…
				FabienAuthorUnsubmitted Done Inline Actions The `PROJECT_HOMEPAGE_URL` is defined by the top-level `project()` declaration. There is no such thing for the description. Regarding the `VENDOR`, a similar text can be found to define the copyright holders in the config files, but even if the text is the same the intent is very different so I left them separated. Fabien: The `PROJECT_HOMEPAGE_URL` is defined by the top-level `project()` declaration. There is no…
				set(CPACK_PACKAGE_HOMEPAGE_URL "${PROJECT_HOMEPAGE_URL}")

				set(CPACK_PACKAGE_INSTALL_DIRECTORY "Bitcoin-abc")
				jasonbcoxUnsubmitted Not Done Inline Actions any reason for the capital 'B'? Seems like this should be `Bitcoin-ABC` or `bitcoin-abc`, not a mix of those. jasonbcox: any reason for the capital 'B'? Seems like this should be `Bitcoin-ABC` or `bitcoin-abc`, not a…
				FabienAuthorUnsubmitted Done Inline Actions This is only to match autotools. I agree it's a bit weird, but if you run an installer from autotools it will install into a `Bitcoin-abc` directory. Fabien: This is only to match autotools. I agree it's a bit weird, but if you run an installer from…
				set(CPACK_RESOURCE_FILE_LICENSE "${CMAKE_SOURCE_DIR}/COPYING")

				if(CMAKE_CROSSCOMPILING)
				set(CPACK_SYSTEM_NAME "${TOOLCHAIN_PREFIX}")
				endif()

				if(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
				set(CPACK_PACKAGE_ICON "${CMAKE_SOURCE_DIR}/share/pixmaps/nsis-header.bmp")
				set(CPACK_GENERATOR "ZIP")
				else()
				set(CPACK_PACKAGE_ICON "${CMAKE_SOURCE_DIR}/share/pixmaps/bitcoin-abc128.png")
				set(CPACK_GENERATOR "TGZ")
				endif()