Page MenuHomePhabricator

[CMAKE] Use CPack to build packages
ClosedPublic

Authored by Fabien on Oct 18 2019, 15:51.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC5928cdaa5b2c: [CMAKE] Use CPack to build packages
Summary

This diff adds a new package build target, which creates one or more
output suitable for installation. For now limited to building a tar.gz
or zip archive of an installation directory, more coming later.

Test Plan

On all platforms:

ninja package

Check the archive output is consistent with the items delivered in our
release binaries archives (requires D4229 for the libbitcoinconsensus
lib and include).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Oct 18 2019, 15:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 18 2019, 15:51
jasonbcox requested changes to this revision.Oct 18 2019, 18:06
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
cmake/modules/PackageOptions.cmake
3 ↗(On Diff #13608)

Seeing as the PROJECT_HOMEPAGE_URL lives somewhere else, shouldn't the vendor and description live in a similar common place also?

6 ↗(On Diff #13608)

any reason for the capital 'B'? Seems like this should be Bitcoin-ABC or bitcoin-abc, not a mix of those.

This revision now requires changes to proceed.Oct 18 2019, 18:06
Fabien requested review of this revision.Oct 18 2019, 19:27
Fabien added inline comments.
cmake/modules/PackageOptions.cmake
3 ↗(On Diff #13608)

The PROJECT_HOMEPAGE_URL is defined by the top-level project() declaration. There is no such thing for the description.
Regarding the VENDOR, a similar text can be found to define the copyright holders in the config files, but even if the text is the same the intent is very different so I left them separated.

6 ↗(On Diff #13608)

This is only to match autotools. I agree it's a bit weird, but if you run an installer from autotools it will install into a Bitcoin-abc directory.

jasonbcox accepted this revision.Oct 18 2019, 21:51

Thanks for explaining. I think there's some minor improvements we can make later, but they don't need to block this diff specifically.

This revision is now accepted and ready to land.Oct 18 2019, 21:51
This revision was automatically updated to reflect the committed changes.