Changeset View
Standalone View
src/secp256k1/CMakeLists.txt
| # Copyright (c) 2017 The Bitcoin developers | # Copyright (c) 2017 The Bitcoin developers | ||||
| cmake_minimum_required(VERSION 3.5) | cmake_minimum_required(VERSION 3.5) | ||||
| project(secp256k1) | project(secp256k1) | ||||
| # Add path for custom modules | # Add path for custom modules | ||||
| set(CMAKE_MODULE_PATH | list(APPEND CMAKE_MODULE_PATH | ||||
| ${CMAKE_MODULE_PATH} | # For building as part of the bitcoin-abc project | ||||
deadalnix: Wait, why is this removed? | |||||
deadalnixUnsubmitted Not Done Inline ActionsOk, append deals with it. deadalnix: Ok, append deals with it. | |||||
FabienAuthorUnsubmitted Done Inline ActionsIt is not, I just switched to list(APPEND). Fabien: It is not, I just switched to `list(APPEND)`. | |||||
deadalnixUnsubmitted Not Done Inline ActionsSaw that after and did D4845 while I was at it. deadalnix: Saw that after and did D4845 while I was at it. | |||||
| ${CMAKE_CURRENT_SOURCE_DIR}/../../cmake/modules | ${CMAKE_CURRENT_SOURCE_DIR}/../../cmake/modules | ||||
deadalnixUnsubmitted Not Done Inline ActionsThat part seems unecessary. deadalnix: That part seems unecessary. | |||||
deadalnixUnsubmitted Not Done Inline ActionsMore on that, you can selectively build secp256k1 while running cmake on the whole project. This does not seems to be serving a use case, and can do very strange stuff on the standalone version, as there may be modules there from some other random project on that filesystem. deadalnix: More on that, you can selectively build secp256k1 while running cmake on the whole project. | |||||
FabienAuthorUnsubmitted Done Inline ActionsThis is needed for building secp256k1 standalone from the bitcoin-abc source tree. Fabien: This is needed for building secp256k1 standalone from the bitcoin-abc source tree.
Maybe the… | |||||
deadalnixUnsubmitted Not Done Inline ActionsBut you can build a standalone version fo it from the abc source tree without it. The only use case it serve is to do so from the abs sourc tree while not running cmake on the rest of the abc project. This is a solution is search of a problem now that we have a specific repository for it. deadalnix: But you can build a standalone version fo it from the abc source tree without it. The only use… | |||||
FabienAuthorUnsubmitted Done Inline ActionsAgreed, I'll put a diff to remove this and rebase Fabien: Agreed, I'll put a diff to remove this and rebase | |||||
| # For building as a standalone project | |||||
| ${CMAKE_SOURCE_DIR}/cmake/modules | |||||
| ) | ) | ||||
| include(AddCompilerFlags) | include(AddCompilerFlags) | ||||
| # libsecp256k1 use a different set of flags. | # libsecp256k1 use a different set of flags. | ||||
| add_compiler_flags( | add_compiler_flags( | ||||
| -pedantic | -pedantic | ||||
| -Wall | -Wall | ||||
| ▲ Show 20 Lines • Show All 225 Lines • Show Last 20 Lines | |||||
Wait, why is this removed?