src/secp256k1/CMakeLists.txt
9 ↗	(On Diff #15195)	More on that, you can selectively build secp256k1 while running cmake on the whole project. This does not seems to be serving a use case, and can do very strange stuff on the standalone version, as there may be modules there from some other random project on that filesystem.

Travis is my next item, I need the build to succeed first :)

src/secp256k1/CMakeLists.txt
8 ↗	(On Diff #15195)	It is not, I just switched to `list(APPEND)`.
9 ↗	(On Diff #15195)	This is needed for building secp256k1 standalone from the bitcoin-abc source tree. Maybe the use case is no longer very relevant since the lib is available as it's own project, but I kept it since it doesn't harm. If you want me to remove it I'll better do it in another diff, as there is a test for this on the CI.

deadalnix requested changes to this revision.Jan 7 2020, 16:20

deadalnix added inline comments.

src/secp256k1/CMakeLists.txt
9 ↗	(On Diff #15195)	But you can build a standalone version fo it from the abc source tree without it. The only use case it serve is to do so from the abs sourc tree while not running cmake on the rest of the abc project. This is a solution is search of a problem now that we have a specific repository for it.

This revision now requires changes to proceed.Jan 7 2020, 16:20

deadalnix added inline comments.Jan 7 2020, 16:20

src/secp256k1/CMakeLists.txt
8 ↗	(On Diff #15195)	Saw that after and did D4845 while I was at it.

Fabien added inline comments.Jan 7 2020, 16:24

src/secp256k1/CMakeLists.txt
9 ↗	(On Diff #15195)	Agreed, I'll put a diff to remove this and rebase

Fabien edited the summary of this revision. (Show Details)Jan 7 2020, 16:41

Fabien added a parent revision: D4846: [CMAKE] Cleanup secp256k1 module path.

Rebase on top of D4846.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8767: Diff 15200.Jan 7 2020, 16:55

deadalnix accepted this revision.Jan 7 2020, 17:20

deadalnix added inline comments.

src/secp256k1/CMakeLists.txt
8 ↗	(On Diff #15200)	Note that you have two comment for one thing, so it' probably a bit redundant. Consider simplifying. # Add path for custom modules when building as a standalone project list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/modules)

This revision is now accepted and ready to land.Jan 7 2020, 17:20

Merge comments.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8768: Diff 15202.Jan 7 2020, 18:06

Closed by commit rABC54d66273f6d0: [CMAKE] Allow building secp256k1 as a standalone project (authored by Fabien). · Explain WhyJan 7 2020, 18:34

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC54d66273f6d0: [CMAKE] Allow building secp256k1 as a standalone project.

@Fabien Should Cmake build instructions be added to the secp256k1 readme at /src/secp256k1/README.md ?
It currently has the autotools build instructions

@Mengerian Yes I'll update the instructions when adding cmake to the Travis build

Fabien added a commit: rSTAGING54d66273f6d0: [CMAKE] Allow building secp256k1 as a standalone project.Apr 7 2020, 22:18

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

CMakeLists.txt

3 lines

Diff 15206

View Options

src/secp256k1/CMakeLists.txt

[CMAKE] Allow building secp256k1 as a standalone projectClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15206

src/secp256k1/CMakeLists.txt

[CMAKE] Allow building secp256k1 as a standalone project
ClosedPublic
Actions

Revision Contents
Changeset List