Page MenuHomePhabricator

[CMAKE] Cleanup secp256k1 module path
ClosedPublic

Authored by Fabien on Tue, Jan 7, 16:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC674034a40326: [CMAKE] Cleanup secp256k1 module path
Summary

Now that secp256k1 has it's own project, there is no need to have it
build standalone from the bitcoin-abc source tree.
It can be selected by using the appropriated target instead.

Test Plan
ninja check check-secp256k1
ABC_BUILD_NAME=build-default ./contrib/teamcity/build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Jan 7, 16:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Jan 7, 16:40
deadalnix accepted this revision.Tue, Jan 7, 17:25
deadalnix added inline comments.
contrib/teamcity/build-configurations.sh
118 ↗(On Diff #15199)

check-secp256k1-java ?

124 ↗(On Diff #15199)

It seems like this could benefit from running ninja check-all / ninja check-extended.

This would ensure this whole test suite also covers univalue and leveldb.

This revision is now accepted and ready to land.Tue, Jan 7, 17:25
Fabien added inline comments.Tue, Jan 7, 17:43
contrib/teamcity/build-configurations.sh
118 ↗(On Diff #15199)

check-secp256k1 includes check-secp256k1-java if -DSECP256K1_ENABLE_JNI is ON.

124 ↗(On Diff #15199)

It's on my stack, I just left it aside lately in favor of other stuff.

This revision was automatically updated to reflect the committed changes.